Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating Invoke-DbaDbUpgrade for #5047 #5066

Merged
merged 1 commit into from
Feb 9, 2019
Merged

updating Invoke-DbaDbUpgrade for #5047 #5066

merged 1 commit into from
Feb 9, 2019

Conversation

tkwj
Copy link
Contributor

@tkwj tkwj commented Feb 9, 2019

Type of Change

  • Bug fix (non-breaking change, fixes Invoke-DbaDbUpgrade - can't pass in more than one db at a time #5047)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

fixes #5047

Approach

Checking if each object is in the array instead of containing the array. Found the issue also applied to the ExcludeDatabase option, fixed here as well.

Commands to test

Screenshots

Learning

@tkwj
updating Invoke-DbaDbUpgrade for dataplat#5047
59a65b4 
this fixes dataplat#5047 by checking if each object is in the array instead of containing the array. Also applied to the ExcludeDatabase option
@potatoqualitee
Copy link
Member

excellent, thank you. works 💯

image

@potatoqualitee potatoqualitee merged commit db1923a into dataplat:development Feb 9, 2019
@tkwj tkwj deleted the Invoke-DbaDbUpgrade-fix5047 branch February 23, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-DbaDbUpgrade - can't pass in more than one db at a time
2 participants
@tkwj @potatoqualitee