Copy-DbaAgentAlert does not validate that operator exist

[danglade]

There is no checking when adding notifications to an alert if the operator exists at destination. This will skip the alert transfer?

[wsmelton]

Logic should be added that if the operator does not exists on the destination instance the alert is to be skipped and output object updated as such.

This should be done prior to this line, being that if the operator does not exist no other action would be successful.

https://github.com/sqlcollaborative/dbatools/blob/3520d96ac90abbd0b14c5f95af789314d43f9d8a/functions/Copy-DbaAgentAlert.ps1#L153

[alevyinroc]

@mikepetrak I did some work toward this as well yesterday, haven't been able to test yet so I didn't log a PR yet. Do you want to take a look? alevyinroc@8a8a8da

[mikepetrak]

Sorry, @alevyinroc , I didn't see that. I scanned your commit and tested it and it looks good to me. Two of the automated tests for my commit failed, so if you log a PR and it passes that sounds good to me.

Describe : Copy-DbaAgentAlert Integration Tests
Context :
Name : It Error occurred in Describe block
Result : Failed
Message : Exception calling "Query" with "1" argument(s): "Exception calling "ExecuteWithResults" with "1" argument(s): "Execute with results failed for Database 'master'. ""

Describe : dbatools style
Context : formatting
Name : It Copy-DbaAgentAlert.ps1 is adopting OTSB formatting style. Please run Invoke-DbatoolsFormatter against the failing file and commit the changes.
Result : Failed
Message : Expected 0, but got 1.