Get-DbaServerRoleMember - Correcting call to child call for Get-DbaLo…

…gin (#5132) * format and correcting connect issue to login cmd * remove restart of agent (test don't require runing state)
dataplat · Mar 4, 2019 · d6077d3 · d6077d3
1 parent dac7c62
commit d6077d3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/functions/Get-DbaServerRoleMember.ps1 b/functions/Get-DbaServerRoleMember.ps1
@@ -81,7 +81,7 @@ function Get-DbaServerRoleMember {
     param (
         [parameter(Position = 0, Mandatory, ValueFromPipeline)]
         [Alias('ServerInstance', 'SqlServer')]
-        [DbaInstance[]]$SqlInstance,
+        [DbaInstanceParameter[]]$SqlInstance,
         [Alias('Credential')]
         [PSCredential]$SqlCredential,
         [string[]]$ServerRole,
@@ -105,9 +105,12 @@ function Get-DbaServerRoleMember {
             $roles = $server.Roles
 
             if (Test-Bound -ParameterName 'Login') {
-                $logins = Get-DbaLogin -SqlInstance $instance -Login $Login
+                try {
+                    $logins = Get-DbaLogin -SqlInstance $server -Login $Login -EnableException
+                } catch {
+                    Stop-Function -Message "Issue gathering login details" -ErrorRecord $_ -Target $instance
+                }
                 Write-Message -Level 'Verbose' -Message "Filtering by logins: $($logins -join ', ')"
-
                 foreach ($l in $logins) {
                     $loginRoles += $l.ListMembers()
                 }

diff --git a/tests/appveyor.SQL2017.ps1 b/tests/appveyor.SQL2017.ps1
@@ -28,7 +28,6 @@ Write-Host -Object "$indent Starting $instance" -ForegroundColor DarkGreen
 #Restart-Service "SQLAgent`$$instance" -WarningAction SilentlyContinue -Force
 
 $null = Enable-DbaAgHadr -SqlInstance $sqlinstance -Confirm:$false -Force
-Restart-Service "SQLAgent`$$instance" -WarningAction SilentlyContinue -Force
 
 do {
     Start-Sleep 1