Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent properties : check for overriding only getter or setter but not both #257

Open
andyjefferson opened this issue Aug 27, 2017 · 0 comments

Comments

@andyjefferson
Copy link
Member

andyjefferson commented Aug 27, 2017

If there is an override of a getter for a persistent property this can result in dnCopyField/dnReplaceField calling dnSetXXX but for the current class and that method is not present for that class, just for the superclass. In the case of only overriding the setter then we will get methods dnCopyField/dnProvideField with the incorrect signatures

We should check for the method in the current class, and either throw an exception informing them to override both, or search for the superclass that has the method.

Workaround : override both setter and getter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant