Why are some bills missing tags on person detail?

[reginafcompton]

(1) Should these bills have tags?
(2) If not, do not show the tag icon.

[reginafcompton]

Solutions

(1) DELETE THESE BILLS FROM OCD and COUNCILMATIC DB
Some of the bills without tags do not appear in Legistar, but they do have an entry in OCD API.

Example of Chin
Land Use Call-Up 2017-6766
OCD API

Land Use Call-Up 2017-5950
OCD API

I filtered for these bills on Chin's Legistar page - with no results: http://legistar.council.nyc.gov/PersonDetail.aspx?ID=42514&GUID=D275DF50-6FAE-446D-B1E7-8AE61BC1C0B8&Search=

Note: I did find other versions of this bill, when searching for its text in the Legistar web interface. I suspect the tag-less bills are ones that NYC created in error, we scraped them, and then a NYC admin removed them. If so, we need to manually remove them from our databases.

(2) WE DO NOT HAVE ENOUGH LOGIC FOR CREATING BILL TOPICS
Tags are populated in this template: https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/templates/partials/legislation_item.html#L26

However, we do not have enough logic for generating topics, just for pseudo topics: https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/models.py#L277

With all that said, we do not facet the bills by "topic" in NYC as we do with Chicago and LA Metro. "Adding topic facets" strikes me as a separate issue and one to be included in the second SOW. For now, we could just add a "tag" that points to the "Controlling Body." Then, it is consistent with what we do in the search results: https://laws.council.nyc.gov/search/?q=&selected_facets=controlling_body_exact%3ACommittee%20on%20Finance

@jeancochrane or @hancush - I'd love to discuss this with either of you, before implementation.

[hancush]

It seems to me that NYC does a lot more altering/deleting of data than we're used to. Maybe we should escalate the priority of shoring up this known weakness of the data importers.

[reginafcompton]

I opened an issue to add "topics" to Bills: #121

@hancush - I think can safely delete those two bills on M. Chin's detail page. I am happy to do it, unless you have an argument against it. And definitely, yes, let's push to get started on that Pupa issue.

[reginafcompton]

Bills deleted! After our deploy on Friday morning, we'll have correct tags elsewhere.

[reginafcompton]

Person detail has tags, now.

But I am now seeing some oddness with the items in the Legislation search tags (which I believe point to "pseudo-topics"...which we do not consistently index in Solr). I'll open a separate issue for this, and close this one.