[BEAM-4744] Enable parallel publishing/release

This solves the problem where jars would overwrite each other when specifying -Ppublishing by fixing classifiers for shadowJar and jar to not conflict when publishing since jar by default uses null.

Note that I also fixed:
* some permissions issues of files
* javadoc issues that came up when I was attempting to publish
* the usage of :runners:google-cloud-dataflow-java:examples and examples-streaming. This was creating an empty project that was being published which was causing issues when attempting to perform a release.

I was able to run a publishToMavenJavaPublicationToMavenLocal in parallel but didn't explicitly enable all the publishing plugins and remove the need for -Ppublishing because I didn't get enough time to test it. This cut publishing time down to about 8 mins from over 20 mins in a clean workspace on my machine.

Author: lukecwik

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -642,7 +642,6 @@ class BeamModulePlugin implements Plugin<Project> {
 
       // Enable errorprone static analysis
       project.apply plugin: 'net.ltgt.errorprone'
-      project.tasks.withType(JavaCompile) { options.compilerArgs += "-XepDisableWarningsInGeneratedCode" }
 
       // Enables a plugin which can perform shading of classes. See the general comments
       // above about dependency management for Java projects and how the shadow plugin
@@ -663,9 +662,14 @@ class BeamModulePlugin implements Plugin<Project> {
         testCompile.extendsFrom shadowTest
       }
 
+      project.jar {
+        classifier = "unshaded"
+        zip64 true
+      }
+
       // Always configure the shadowJar classifier and merge service files.
       project.shadowJar({
-        classifier = "shaded"
+        classifier = null
         mergeServiceFiles()
         zip64 true
         into("META-INF/") {
@@ -678,7 +682,7 @@ class BeamModulePlugin implements Plugin<Project> {
       project.task('shadowTestJar', type: ShadowJar, {
         group = "Shadow"
         description = "Create a combined JAR of project and test dependencies"
-        classifier = "shaded-tests"
+        classifier = "tests"
         from project.sourceSets.test.output
         configurations = [
           project.configurations.testRuntime
@@ -797,12 +801,11 @@ artifactId=${project.name}
 
           publications {
             mavenJava(MavenPublication) {
-              artifact project.shadowJar { // Strip the "shaded" classifier.
-                classifier null }
-              artifact project.shadowTestJar, { classifier "tests" }
-              artifact project.sourcesJar, { classifier "sources" }
-              artifact project.testSourcesJar, { classifier "testSources" }
-              artifact project.javadocJar, { classifier "javadoc" }
+              artifact project.shadowJar
+              artifact project.shadowTestJar
+              artifact project.sourcesJar
+              artifact project.testSourcesJar
+              artifact project.javadocJar
 
               pom {
                 name = project.description

examples/java/build.gradle

@@ -123,7 +123,7 @@ task preCommit() {
   for (String runner : preCommitRunners) {
     dependsOn runner + "PreCommit"
   }
-  dependsOn ":runners:google-cloud-dataflow-java:examples:preCommit"
-  dependsOn ":runners:google-cloud-dataflow-java:examples-streaming:preCommit"
+  dependsOn ":beam-runners-google-cloud-dataflow-java-examples:preCommit"
+  dependsOn ":beam-runners-google-cloud-dataflow-java-examples-streaming:preCommit"
 }
 

model/fn-execution/build.gradle

@@ -23,8 +23,8 @@ description = "Apache Beam :: Model :: Fn Execution"
 ext.summary = "Portable definitions for execution user-defined functions."
 
 dependencies {
-  // We purposely depend on the unshaded classes for compilation and
+  // We purposely depend on the unshaded classes for protobuf compilation and
   // export the shaded variant as the actual runtime dependency.
-  compile project(path: ":beam-model-pipeline")
+  protobuf project(path: ":beam-model-pipeline", configuration: "unshaded")
   runtime project(path: ":beam-model-pipeline", configuration: "shadow")
 }

model/job-management/build.gradle

@@ -23,8 +23,8 @@ description = "Apache Beam :: Model :: Job Management"
 ext.summary = "Portable definitions for submitting pipelines."
 
 dependencies {
-  // We purposely depend on the unshaded classes for compilation and
+  // We purposely depend on the unshaded classes for protobuf compilation and
   // export the shaded variant as the actual runtime dependency.
-  compile project(path: ":beam-model-pipeline")
+  protobuf project(path: ":beam-model-pipeline", configuration: "unshaded")
   runtime project(path: ":beam-model-pipeline", configuration: "shadow")
 }

model/pipeline/build.gradle

@@ -21,3 +21,11 @@ applyPortabilityNature()
 
 description = "Apache Beam :: Model :: Pipeline"
 ext.summary = "Portable definitions for building pipelines"
+
+configurations {
+    unshaded
+}
+
+artifacts {
+    unshaded jar
+}

runners/google-cloud-dataflow-java/examples-streaming/build.gradle

@@ -44,7 +44,7 @@ task preCommit(type: Test) {
   testClassesDirs = files(project(":beam-examples-java").sourceSets.test.output.classesDirs)
   include "**/WordCountIT.class"
   // Don't include WindowedWordCountIT, since it is already included in
-  // :runners:google-cloud-dataflow-java:examples:preCommit and runs
+  // :beam-runners-google-cloud-dataflow-java-examples:preCommit and runs
   // identically (ignores the --streaming flag).
   forkEvery 1
   maxParallelForks 4

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java

@@ -26,9 +26,10 @@ public interface FnService extends AutoCloseable, BindableService {
    * {@inheritDoc}.
    *
    * <p>There should be no more calls to any service method by the time a call to {@link #close()}
-   * begins. Specifically, this means that a {@link io.grpc.Server} that this service is bound to
-   * should have completed a call to the {@link io.grpc.Server#shutdown()} method, and all future
-   * incoming calls will be rejected.
+   * begins. Specifically, this means that a {@link org.apache.beam.vendor.grpc.v1.io.grpc.Server}
+   * that this service is bound to should have completed a call to the {@link
+   * org.apache.beam.vendor.grpc.v1.io.grpc.Server#shutdown()} method, and all future incoming calls
+   * will be rejected.
    */
   @Override
   void close() throws Exception;

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/CustomSources.java

@@ -325,13 +325,13 @@ private <K, V, W extends BoundedWindow> SideInputHandler<V, W> createHandler(
    * Returns an adapter which converts a {@link BagUserStateHandlerFactory} to a {@link
    * StateRequestHandler}.
    *
-   * <p>The {@link MultimapSideInputHandlerFactory} is required to handle all multimap side inputs
-   * contained within the {@link ExecutableProcessBundleDescriptor}. See {@link
-   * ExecutableProcessBundleDescriptor#getMultimapSideInputSpecs} for the set of multimap side
-   * inputs that are contained.
+   * <p>The {@link SideInputHandlerFactory} is required to handle all multimap side inputs contained
+   * within the {@link ExecutableProcessBundleDescriptor}. See {@link
+   * ExecutableProcessBundleDescriptor#getSideInputSpecs} for the set of multimap side inputs that
+   * are contained.
    *
-   * <p>Instances of {@link MultimapSideInputHandler}s returned by the {@link
-   * MultimapSideInputHandlerFactory} are cached.
+   * <p>Instances of {@link SideInputHandler}s returned by the {@link SideInputHandlerFactory} are
+   * cached.
    */
   public static StateRequestHandler forBagUserStateHandlerFactory(
       ExecutableProcessBundleDescriptor processBundleDescriptor,

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/package-info.java

@@ -50,10 +50,10 @@ include "beam-runners-gearpump"
 project(":beam-runners-gearpump").dir = file("runners/gearpump")
 include "beam-runners-google-cloud-dataflow-java"
 project(":beam-runners-google-cloud-dataflow-java").dir = file("runners/google-cloud-dataflow-java")
-// These 2 projects will not be published to Maven so they don't get a special
-// dashed name.
-include ":runners:google-cloud-dataflow-java:examples"
-include ":runners:google-cloud-dataflow-java:examples-streaming"
+include ":beam-runners-google-cloud-dataflow-java-examples"
+project(":beam-runners-google-cloud-dataflow-java-examples").dir = file("runners/google-cloud-dataflow-java/examples")
+include ":beam-runners-google-cloud-dataflow-java-examples-streaming"
+project(":beam-runners-google-cloud-dataflow-java-examples-streaming").dir = file("runners/google-cloud-dataflow-java/examples")
 include "beam-runners-java-fn-execution"
 project(":beam-runners-java-fn-execution").dir = file("runners/java-fn-execution")
 include "beam-runners-local-java-core"