Implement multi-sv detection #2510

pradh · 2023-03-29T07:58:14Z

Roughly as described in this doc. Not hooked up to fulfillment yet. Propagated to debug info (screenshot below).

This PR moves the stop-word removal done for single-sv detection from website server to nl server. This is so that multi-sv detection can be done with the stop-words present.

BUG=#2397

…to nlbugs8

shifucun · 2023-03-29T23:52:13Z

static/js/apps/nl_interface/debug_info.tsx

+                      {c.Parts.map((p) => {
+                        return (
+                          <li key={p.QueryPart}>
+                            [{p.QueryPart}]
+                            <ul>
+                              {p.SV.length === p.CosineScore.length &&
+                                p.SV.map((sv, i) => {
+                                  return (
+                                    <li key={i}>
+                                      {sv} ({p.CosineScore[i]})
+                                    </li>
+                                  );
+                                })}
+                            </ul>
+                          </li>
+                        );
+                      })}


nit: make a helper component to wrap this

shifucun · 2023-03-30T01:31:40Z

nl_server/embeddings.py


 TEMP_DIR = '/tmp/'
 MODEL_NAME = 'all-MiniLM-L6-v2'

+# A value higher than the highest score.
+_INIT_SCORE = 1.1


Maybe have _HIGHEST_SCORE and use (_HIGHEST_SCORE + 0.1) for _INIT_SCORE so the purpose is more apparent?

shifucun · 2023-03-30T01:33:17Z

nl_server/embeddings.py

+  svs: List[str]
+  scores: List[float]
+  sv2sentences: Dict[str, List[str]]


Might not worth a change for now, but why not having a list of {sv, score, sentences} struct?

It has been that way from before, so not changing it now.

shifucun · 2023-03-30T01:34:18Z

nl_server/embeddings.py

+class MultiVarCandidate:
+  parts: List[MultiVarCandidatePart]
+  # Aggregate score
+  score: float


use "aggregate_score" explicitly?

shifucun · 2023-03-30T01:35:39Z

nl_server/embeddings.py

+@dataclass
+class MultiVarCandidates:
+  candidates: List[MultiVarCandidate]
+  sv2sentences: Dict[str, List[str]]


why sv2sentences is not in MultiVarCandidate? what is they key (one stat var) mean in a multiVarCandidates scenario.

sv2sentences is a debug map of sentences that we matched for each SV in the index. But it is not used at the moment, so let me remove and add it in later PR.

shifucun · 2023-03-30T01:37:53Z

nl_server/embeddings.py

-    scores_sorted = [v for (_, v) in sv2score_sorted]
-
-    sv_index_sorted = [sv2index[k] for (k, _) in sv2score_sorted]
+    query2sv2sentence2score: Dict[str, Dict[str, Dict[str, float]]] = {}


have a comment with an example of query2sv2sentence2score?

Described it.

shifucun · 2023-03-30T01:38:39Z

nl_server/embeddings.py

+
+    query2result: Dict[str, VarCandidates] = {}
+
+    for q, sv2score in query2sv2score.items():


Have a comment for this and the next large for loop on what it processes?

shifucun · 2023-03-30T01:40:12Z

nl_server/embeddings.py

-        'SV_to_Sentences': all_svs_sentences,
+        'SV': result_monovar.svs,
+        'CosineScore': result_monovar.scores,
+        'SV_to_Sentences': result_monovar.sv2sentences,


Use CamelCase too?

This is from before, and will touch a few unrelated places, so can change in a follow on PR. Added TODO

shifucun · 2023-03-30T01:42:02Z

nl_server/embeddings.py

+    #
+    # TODO: Come up with a better ranking function.
+    #
+    for qs in querysets:


Some examples of "querysets" is helpful, since its fields are very deep

Done, PTAL.

pradh

Thanks for the review Bo!

pradh · 2023-03-30T02:23:56Z

nl_server/embeddings.py


 TEMP_DIR = '/tmp/'
 MODEL_NAME = 'all-MiniLM-L6-v2'

+# A value higher than the highest score.
+_INIT_SCORE = 1.1


pradh · 2023-03-30T02:24:31Z

nl_server/embeddings.py

+  svs: List[str]
+  scores: List[float]
+  sv2sentences: Dict[str, List[str]]


It has been that way from before, so not changing it now.

pradh · 2023-03-30T02:24:58Z

nl_server/embeddings.py

+class MultiVarCandidate:
+  parts: List[MultiVarCandidatePart]
+  # Aggregate score
+  score: float


pradh · 2023-03-30T02:29:02Z

nl_server/embeddings.py

+@dataclass
+class MultiVarCandidates:
+  candidates: List[MultiVarCandidate]
+  sv2sentences: Dict[str, List[str]]


sv2sentences is a debug map of sentences that we matched for each SV in the index. But it is not used at the moment, so let me remove and add it in later PR.

pradh · 2023-03-30T02:30:47Z

nl_server/embeddings.py

-        'SV_to_Sentences': all_svs_sentences,
+        'SV': result_monovar.svs,
+        'CosineScore': result_monovar.scores,
+        'SV_to_Sentences': result_monovar.sv2sentences,


This is from before, and will touch a few unrelated places, so can change in a follow on PR. Added TODO

pradh · 2023-03-30T02:52:58Z

static/js/apps/nl_interface/debug_info.tsx

+                      {c.Parts.map((p) => {
+                        return (
+                          <li key={p.QueryPart}>
+                            [{p.QueryPart}]
+                            <ul>
+                              {p.SV.length === p.CosineScore.length &&
+                                p.SV.map((sv, i) => {
+                                  return (
+                                    <li key={i}>
+                                      {sv} ({p.CosineScore[i]})
+                                    </li>
+                                  );
+                                })}
+                            </ul>
+                          </li>
+                        );
+                      })}


pradh · 2023-03-30T02:54:28Z

nl_server/embeddings.py

-    scores_sorted = [v for (_, v) in sv2score_sorted]
-
-    sv_index_sorted = [sv2index[k] for (k, _) in sv2score_sorted]
+    query2sv2sentence2score: Dict[str, Dict[str, Dict[str, float]]] = {}


Described it.

pradh · 2023-03-30T02:55:48Z

nl_server/embeddings.py

+
+    query2result: Dict[str, VarCandidates] = {}
+
+    for q, sv2score in query2sv2score.items():


pradh · 2023-03-30T03:02:03Z

nl_server/embeddings.py

+    #
+    # TODO: Come up with a better ranking function.
+    #
+    for qs in querysets:


Done, PTAL.

jehangiramjad

Apologies for the delay. Some comments which might be good to discuss

jehangiramjad · 2023-03-30T16:03:18Z

nl_server/embeddings.py

+  # Given a list of queries, searches the in-memory embeddings index
+  # and returns a map of candidates keyed by input queries.
+  #
+  def _search_embeddings(self, queries: List[str]) -> Dict[str, VarCandidates]:


Question: why do the refactor of this function in the same PR as the introduction of a new function for detecting multi svs? Is there some functionality that was missing which this refactor addresses?

The refactor takes multiple queries and returns results, which was needed for the multi SV case.

jehangiramjad · 2023-03-30T16:11:31Z

nl_server/query_util.py

+  combinations: List[QuerySplit]
+
+
+#


It would be great to document this with some examples. With the recursive calls inside this function, highly recommended extensive documentation because it is fairly hairy to figure out what's going on. I also recommend more comments to help step line by line.

I'm adding comments and unit tests in a follow on PR.

jehangiramjad · 2023-03-30T16:20:51Z

nl_server/embeddings.py

+    #
+    # Prepare a combination of query-sets.
+    #
+    querysets = query_util.prepare_multivar_querysets(query)


Reading the comments below about a queryset, wouldn't it be better to use this combinatorial API/function built in to python? https://www.geeksforgeeks.org/itertools-combinations-module-python-print-possible-combinations/

good idea. doing in the follow on PR.

@jehangiramjad

Fold in the great feedback from @jehangiramjad on #2510. This also fixes a bug in previous implementation.

@chayim

Bumps [redis](https://github.com/redis/redis-py) from 3.5.3 to 4.5.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/releases">redis's releases</a>.</em></p> <blockquote> <h2>4.5.3</h2> <h1>Changes</h1> <p>Update urgency: HIGH: There is a critical bug that may affect a subset of users. Upgrade!</p> <h2>🐛 Bug Fixes</h2> <ul> <li><a href="https://cwe.mitre.org/data/definitions/404.html">CWE-404</a> AsyncIO Race Condition Fix (<a href="https://github.com/redis/redis-py/issues/2624">#2624</a>, <a href="https://github.com/redis/redis-py/issues/2579">#2579</a>)</li> </ul> <h2>4.5.2</h2> <h1>Changes</h1> <h2>🚀 New Features</h2> <ul> <li>Introduce AbstractConnection so that UnixDomainSocketConnection can call super().<strong>init</strong> (<a href="https://github.com/redis/redis-py/issues/2588">#2588</a>)</li> <li>Added queue_class to REDIS_ALLOWED_KEYS (<a href="https://github.com/redis/redis-py/issues/2577">#2577</a>)</li> <li>Made search document subscriptable (<a href="https://github.com/redis/redis-py/issues/2615">#2615</a>)</li> <li>Sped up the protocol parsing (<a href="https://github.com/redis/redis-py/issues/2596">#2596</a>)</li> </ul> <h2>🐛 Bug Fixes</h2> <ul> <li>Fix behaviour of async PythonParser to match RedisParser as for issue <a href="https://github.com/redis/redis-py/issues/2349">#2349</a> (<a href="https://github.com/redis/redis-py/issues/2582">#2582</a>)</li> <li>Replace async_timeout by asyncio.timeout (<a href="https://github.com/redis/redis-py/issues/2602">#2602</a>)</li> <li>Update json().arrindex() default values (<a href="https://github.com/redis/redis-py/issues/2611">#2611</a>)</li> </ul> <h2>🧰 Maintenance</h2> <ul> <li>Coverage for pypy-3.9 (<a href="https://github.com/redis/redis-py/issues/2608">#2608</a>)</li> <li>Developer Experience: Adding redis version compatibility details to the README (<a href="https://github.com/redis/redis-py/issues/2621">#2621</a>)</li> <li>Remove redundant assignment to RedisCluster.nodes_manager. (<a href="https://github.com/redis/redis-py/issues/2620">#2620</a>)</li> <li>Developer Experience: [types] update return type of smismember to list[int] (<a href="https://github.com/redis/redis-py/issues/2617">#2617</a>)</li> <li>Developer Experience: [docs] ConnectionPool SSL example (<a href="https://github.com/redis/redis-py/issues/2605">#2605</a>)</li> <li>Developer Experience: Fixed CredentialsProvider examples (<a href="https://github.com/redis/redis-py/issues/2587">#2587</a>)</li> <li>Developer Experience: Update README to make pip install copy-pastable on zsh (<a href="https://github.com/redis/redis-py/issues/2584">#2584</a>)</li> <li>Developer Experience: Fix for <code>lpop</code> and <code>rpop</code> return typing (<a href="https://github.com/redis/redis-py/issues/2590">#2590</a>)</li> </ul> <h2>Contributors</h2> <p>We'd like to thank all the contributors who worked on this release!</p> <p><a href="https://github.com/CrimsonGlory"><code>@CrimsonGlory</code></a>, <a href="https://github.com/Galtozzy"><code>@Galtozzy</code></a>, <a href="https://github.com/aksinha334"><code>@aksinha334</code></a>, <a href="https://github.com/barshaul"><code>@barshaul</code></a>, <a href="https://github.com/chayim"><code>@chayim</code></a>, <a href="https://github.com/davemcphee"><code>@davemcphee</code></a>, <a href="https://github.com/dvora-h"><code>@dvora-h</code></a>, <a href="https://github.com/kristjanvalur"><code>@kristjanvalur</code></a>, <a href="https://github.com/ryin1"><code>@ryin1</code></a>, <a href="https://github.com/sileht"><code>@sileht</code></a>, <a href="https://github.com/thebarbershop"><code>@thebarbershop</code></a>, <a href="https://github.com/uglide"><code>@uglide</code></a>, <a href="https://github.com/woutdenolf"><code>@woutdenolf</code></a> and <a href="https://github.com/zakaf"><code>@zakaf</code></a></p> <h2>4.5.1</h2> <h1>Changes</h1> <h2>🐛 Bug Fixes</h2> <ul> <li>Fix <a href="https://github.com/redis/redis-py/issues/2581">#2581</a> <code>UnixDomainSocketConnection</code> object has no attribute <code>_command_packer</code> (<a href="https://github.com/redis/redis-py/issues/2583">#2583</a>)</li> </ul> <h2>Contributors</h2> <p>We'd like to thank all the contributors who worked on this release!</p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/blob/master/CHANGES">redis's changelog</a>.</em></p> <blockquote> <pre><code>* Allow data to drain from async PythonParser when reading during a disconnect() * Use asyncio.timeout() instead of async_timeout.timeout() for python >= 3.11 ([datacommonsorg#2602](redis/redis-py#2602)) * Add test and fix async HiredisParser when reading during a disconnect() ([datacommonsorg#2349](redis/redis-py#2349)) * Use hiredis-py pack_command if available. * Support `.unlink()` in ClusterPipeline * Simplify synchronous SocketBuffer state management * Fix string cleanse in Redis Graph * Make PythonParser resumable in case of error ([datacommonsorg#2510](redis/redis-py#2510)) * Add `timeout=None` in `SentinelConnectionManager.read_response` * Documentation fix: password protected socket connection ([datacommonsorg#2374](redis/redis-py#2374)) * Allow `timeout=None` in `PubSub.get_message()` to wait forever * add `nowait` flag to `asyncio.Connection.disconnect()` * Update README.md links * Fix timezone handling for datetime to unixtime conversions * Fix start_id type for XAUTOCLAIM * Remove verbose logging from cluster.py * Add retry mechanism to async version of Connection * Compare commands case-insensitively in the asyncio command parser * Allow negative `retries` for `Retry` class to retry forever * Add `items` parameter to `hset` signature * Create codeql-analysis.yml ([datacommonsorg#1988](redis/redis-py#1988)). Thanks @chayim * Add limited support for Lua scripting with RedisCluster * Implement `.lock()` method on RedisCluster * Fix cursor returned by SCAN for RedisCluster & change default target to PRIMARIES * Fix scan_iter for RedisCluster * Remove verbose logging when initializing ClusterPubSub, ClusterPipeline or RedisCluster * Fix broken connection writer lock-up for asyncio ([datacommonsorg#2065](redis/redis-py#2065)) * Fix auth bug when provided with no username ([datacommonsorg#2086](redis/redis-py#2086)) * Fix missing ClusterPipeline._lock ([datacommonsorg#2189](redis/redis-py#2189)) * Added dynaminc_startup_nodes configuration to RedisCluster * Fix reusing the old nodes' connections when cluster topology refresh is being done * Fix RedisCluster to immediately raise AuthenticationError without a retry * ClusterPipeline Doesn't Handle ConnectionError for Dead Hosts ([datacommonsorg#2225](redis/redis-py#2225)) * Remove compatibility code for old versions of Hiredis, drop Packaging dependency * The `deprecated` library is no longer a dependency * Failover handling improvements for RedisCluster and Async RedisCluster ([datacommonsorg#2377](redis/redis-py#2377)) * Fixed "cannot pickle '_thread.lock' object" bug ([datacommonsorg#2354](redis/redis-py#2354), [datacommonsorg#2297](redis/redis-py#2297)) * Added CredentialsProvider class to support password rotation * Enable Lock for asyncio cluster mode * Fix Sentinel.execute_command doesn't execute across the entire sentinel cluster bug ([datacommonsorg#2458](redis/redis-py#2458)) * Added a replacement for the default cluster node in the event of failure ([datacommonsorg#2463](redis/redis-py#2463)) * Fix for Unhandled exception related to self.host with unix socket ([datacommonsorg#2496](redis/redis-py#2496)) </code></pre> <ul> <li>4.1.3 (Feb 8, 2022) <ul> <li>Fix flushdb and flushall (<a href="https://github.com/redis/redis-py/issues/1926">#1926</a>)</li> <li>Add redis5 and redis4 dockers (<a href="https://github.com/redis/redis-py/issues/1871">#1871</a>)</li> <li>Change json.clear test multi to be up to date with redisjson (<a href="https://github.com/redis/redis-py/issues/1922">#1922</a>)</li> <li>Fixing volume for unstable_cluster docker (<a href="https://github.com/redis/redis-py/issues/1914">#1914</a>)</li> <li>Update changes file with changes since 4.0.0-beta2 (<a href="https://github.com/redis/redis-py/issues/1915">#1915</a>)</li> </ul> </li> <li>4.1.2 (Jan 27, 2022)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/redis/redis-py/commit/66a4d6b2a493dd3a20cc299ab5fef3c14baad965"><code>66a4d6b</code></a> AsyncIO Race Condition Fix (<a href="https://github.com/redis/redis-py/issues/2641">#2641</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/318b114f4da9846a2a7c150e1fb702e9bebd9fdf"><code>318b114</code></a> Version 4.5.2 (<a href="https://github.com/redis/redis-py/issues/2627">#2627</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/1b2f408259405d412d7530291902f9e0c8bd34b3"><code>1b2f408</code></a> Fix behaviour of async PythonParser to match RedisParser as for issue <a href="https://github.com/redis/redis-py/issues/2349">#2349</a> (...</li> <li><a href="https://github.com/redis/redis-py/commit/7d474f90453c7b90bd06c94e0250b618120a599d"><code>7d474f9</code></a> introduce AbstractConnection so that UnixDomainSocketConnection can call supe...</li> <li><a href="https://github.com/redis/redis-py/commit/c87172347584301f453c601c483126e4800257b7"><code>c871723</code></a> pypy-3.9 CI (<a href="https://github.com/redis/redis-py/issues/2608">#2608</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/d63313bf6080acaf18d61e072c78303adc0d4166"><code>d63313b</code></a> add queue_class to REDIS_ALLOWED_KEYS (<a href="https://github.com/redis/redis-py/issues/2577">#2577</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/c61eeb2e3b5dff1f01eb1e665f424c7e75354f56"><code>c61eeb2</code></a> Adding supported redis/library details (<a href="https://github.com/redis/redis-py/issues/2621">#2621</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/25e85e51e57b7aae9eb8fc77cfb0a45a07a501a7"><code>25e85e5</code></a> fix: replace async_timeout by asyncio.timeout (<a href="https://github.com/redis/redis-py/issues/2602">#2602</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/91ab12a0f1bdf0e433131e1a51578e9fa2f89718"><code>91ab12a</code></a> Remove redundant assignment. (<a href="https://github.com/redis/redis-py/issues/2620">#2620</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/8bfd492240fd33489a86cd3d353e3ece1fc94c10"><code>8bfd492</code></a> Making search document subscriptable (<a href="https://github.com/redis/redis-py/issues/2615">#2615</a>)</li> <li>Additional commits viewable in <a href="https://github.com/redis/redis-py/compare/3.5.3...v4.5.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=redis&package-manager=pip&previous-version=3.5.3&new-version=4.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/datacommonsorg/website/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bo Xu <[email protected]>

pradh added 3 commits March 28, 2023 23:48

Multi statvar handling

176dec4

Merge branch 'master' of https://github.com/datacommonsorg/website in…

03519ee

…to nlbugs8

Add comments and more tests.

d511dd8

pradh requested review from jehangiramjad and shifucun March 29, 2023 07:58

pradh added 4 commits March 29, 2023 00:59

Merge branch 'master' of https://github.com/datacommonsorg/website in…

431b6a8

…to nlbugs8

Merge branch 'master' of https://github.com/datacommonsorg/website in…

f6ada11

…to nlbugs8

Update tests

fe937ed

Revert constants.py change that doesn't belong here.

230e5e1

shifucun reviewed Mar 30, 2023

View reviewed changes

Handle review comments

f8805cc

pradh commented Mar 30, 2023

View reviewed changes

shifucun approved these changes Mar 30, 2023

View reviewed changes

Merge branch 'master' into nlbugs8

46ac9eb

pradh enabled auto-merge (squash) March 30, 2023 15:54

pradh merged commit f84c7c1 into datacommonsorg:master Mar 30, 2023

jehangiramjad reviewed Mar 30, 2023

View reviewed changes

pradh mentioned this pull request Mar 31, 2023

Improve multi-sv query combination computation #2522

Merged

pradh added a commit that referenced this pull request Mar 31, 2023

Improve multi-sv query combination computation (#2522)

2bcd7ef

Fold in the great feedback from @jehangiramjad on #2510. This also fixes a bug in previous implementation.


		query2result: Dict[str, VarCandidates] = {}

		for q, sv2score in query2sv2score.items():

Implement multi-sv detection #2510

Implement multi-sv detection #2510

Conversation

pradh commented Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pradh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jehangiramjad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pradh commented Mar 29, 2023 •

edited

Loading