Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google maps scrolling issue #2245

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

juliawu
Copy link
Contributor

@juliawu juliawu commented Feb 16, 2023

After PR #2189, google map tiles with KML coordinates drawn don't let the user scroll or pan.

This PR removes the listener added as a quick-fix, and instead fixes a CSS bug that caused map heights to sometimes be set to 0.

Before:

Screen.Recording.2023-02-15.at.1.55.46.PM.mov

After:

Screen.Recording.2023-02-15.at.1.57.33.PM.mov

Also tested the changes on the following pages:

Place pages:

  • San Francisco City
  • California
  • USA (no maps expected)
  • India (no maps expected)

Browser pages:

  • Mountain View
  • Santa Clara County
  • Alaska
  • India

NL interface:

  • "Tell me about palo alto"
  • "Tell me about Santa Clara County"
  • "Tell me about Nebraska"
  • "Tell me about USA"

Copy link
Contributor

@chejennifer chejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@juliawu juliawu merged commit 33212a8 into datacommonsorg:master Feb 16, 2023
@juliawu juliawu deleted the google-map-fixes branch May 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants