Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client allowed sub domains can have spaces #89

Closed
richardhallett opened this issue Jul 4, 2018 · 1 comment
Closed

Client allowed sub domains can have spaces #89

richardhallett opened this issue Jul 4, 2018 · 1 comment
Assignees
Labels

Comments

@richardhallett
Copy link
Contributor

Currently when adding sub-domains to a client you can additionally add a space before the subdomain, this causes problems when trying to register a domain as it treats that space as part of the subdomain.

In addition, there is no error message being surfaced about this in Fabrica, in the old MDS UI this would cause a "domain not allowed", however Fabrica accepts the URL but does not actually register it, therefore putting it in a "Findable" state incorrectly.

Reproduce:

  1. Add a subdomain to client like "google.com, example.com"
  2. Try registering a URL
  3. Notice registration doesn't cause an error
  4. Notice it's not actually registered

Proposed solution:

  1. Strip spaces around sub domains
  2. Add errors about invalid domains surfaced in Fabrica
@richardhallett
Copy link
Contributor Author

Simple fix of just stripping whitespace.

@ghost ghost removed the development label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants