API doesn't fail when nameIdentifiers is sent as a object rather the as an array

[MaryHirsch]

Expected Behaviour

Access list of DOIs by clicking on DOIs tab

Current Behaviour

DOIs tab blank

Steps to Reproduce

https://doi.datacite.org/repositories/bf.discover/dois

Context (Environment)

it can be found in the api

https://api.datacite.org/dois?client-id=bf.discover
https://api.datacite.org/clients/bf.discover/dois

Fabrica production

Hypothesis

Detailed Description

Possible Implementation

Front conversations

[kjgarza]

maybe related to https://app.frontapp.com/open/msg_e9onoph

[kjgarza]

or maybe related to https://app.frontapp.com/open/msg_45cz9mr

[kjgarza]

none of the DOIs seem to have a source https://api.datacite.org/clients/bf.discover/dois

[kjgarza]

commented all other fragmentArray declaration in the DOI model until i found the one that is failing. that was name_identifiers. For some reasons bf.dissocvery was able to mint doi with an object rather than an array in this field.

// contributors: fragmentArray('contributor', { defaultValue: [] }),

[mfenner]

Good catch @kjgarza! Is nameIdentifiers as object possible with the form or one of the APIs?

And I suggest to update the DOI using the XML upload form.

[kjgarza]

The form doesn't allow that. it must have been made with an API. It seems to be many of their dois (or all), Which is strange.

I don't think they can use XML upload to fix it,because one cannot go into the doi page. we will probably need to update them via a rake tasks. They only need a touch to be fixed. there is no need to modify the metadata.

[mfenner]

Makes sense, thanks.

[jwagenaar]

Hi all, thanks for looking into this. Copying our engineer @JeremyLecoeur in case you have any questions.

[JeremyLecoeur]

Hello, I'm the dev responsible on blackfynn side for the DOI requests change that added the name identifier. I see where I made a mistake and I can correct it easily. You were correct in assuming we use the API to update the DOIs. I'm surprised that I did not receive an error code in response since the request was malformed.

[kjgarza]

@JeremyLecoeur could you let us know which endpoint did you use? We can review the validation on that endpoint to avoid that problem in the future.

[JeremyLecoeur]

I used the PATCH https://api.datacite.org/dois/{doi} endpoint

[kjgarza]

@JeremyLecoeur could you paste the payload you were sending before ? that would help me to define changes in the validation if needed