Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name field not autopopulated when unknown radio button selected #438

Closed
MaryHirsch opened this issue Jun 18, 2020 · 4 comments
Closed

Name field not autopopulated when unknown radio button selected #438

MaryHirsch opened this issue Jun 18, 2020 · 4 comments
Assignees

Comments

@MaryHirsch
Copy link

MaryHirsch commented Jun 18, 2020

Expected Behaviour

The form autopopulates the name field when the given name and family name are entered

Current Behaviour

The "name" field does not autopopulate, seems to be when the radio button "unknown" is selected (this is default)

Screen Shot 2020-06-18 at 14 52 49

Steps to Reproduce

  1. create a doi via form

Context (Environment)

Fabrica form

Hypothesis

Detailed Description

Possible Implementation

@mfenner
Copy link
Contributor

mfenner commented Jun 18, 2020

@MaryHirsch this is expected behaviour. Automatic name generation based on given name and family name requires nameType Personal.

@MaryHirsch
Copy link
Author

@mfenner this was reported by an end user. it could be confusing. Maybe this could be a feature request for a message to select the "person" radio button

@kjgarza
Copy link
Contributor

kjgarza commented Jul 6, 2020

@mfenner @MaryHirsch Could we clarify what the correct behaviour is this feature? This doesn't seem to be a bug.

@mfenner
Copy link
Contributor

mfenner commented Jul 6, 2020

Defaulting to nameType personal has created issues in the past, and thus we have moved away from it. I suggest to update the documentation, but not make any changes in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants