Tests for publicationYear form field

[mfenner]

Child of #140.

[kjgarza]

Started with the Rendering test but there seems to be something i'm missing, will need to investigate further.

error:

            { type: 'error',
              testContext:
               { id: 3,
                 name: 'Integration | Component | doi-form: it rejects non integers',
                 items: [],
                 state: 'executing' },
              text: 'Uncaught TypeError: Cannot read property \'get\' of undefined at http://localhost:7357/assets/bracco.js, line 2764\n' }
    ...
not ok 6 Chrome 72.0 - [178 ms] - Integration | Component | doi-form: it rejects non integers
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/bracco.js:2764
        message: >
            Uncaught TypeError: Cannot read property 'get' of undefined
        negative: >
            false
        Log: |
    ...

spec

  test('it rejects non integers', async function(assert) {
    assert.expect(1);

    this.set('publicationYear', 'red');
    await render(hbs`{{doi-form}}`);

    assert.equal(this.element.querySelector("div.help-block").innerText, 'Must be between 1450 and 2020.');
    assert.equal(this.element.querySelector("label.control-label.col-md-3").getAttribute('style'), 'color: #e74c3c');
  });

[mfenner]

Share the complete test code. Use assert.dom. https://github.com/simplabs/qunit-dom. Run the test in the browser to see what the test is seeing.

[kjgarza]

Questions:

• Can I fully separate the the form into components. Fields such as Publisher and Publicationyear are in the doi-form component. this means that we have to test the whole form to tests those component ?
  

  bracco/app/templates/components/doi-form.hbs

  Line 18 in ae3967d

  {{form.element controlType="text" label="Publisher" property="publisher" helpText="The name of the entity that

• I would like to have very clear the Testing Specs. I prepared some intial specs Tests for Fabrica form #140 . But I would like to feedback.
• How do we deal with refractoring?

Blockers:

• I have not been able to render ember-bootstrap elemnts (form.element).
  • I think its because some elements do not stand on their own. for example, doesn't have the surounder form field

    bracco/app/templates/components/doi-titles.hbs

    Line 1 in ae3967d

    {{form.element controlType="textarea" label="Title" property="titles" rows=2 helpText="A name or title by which the

    • richard pointout that I can replicate the enclosing element in the form
• Even when adding enclosing elements. I canot render the bs-form at the moment.

[kjgarza]

allowed value 73fb618
multiple values N/A
missing value a261d08
incorrect value(s) a261d08
insufficient permissions N/A
adding/editing/deleting of values in c52107f