From c6bf2b2c7e26a47b1551c293ca83ffd495b04508 Mon Sep 17 00:00:00 2001 From: dipankarkusha-db Date: Tue, 10 Oct 2023 17:30:22 -0400 Subject: [PATCH] Added checking for index out of range. Fixes #428 --- tests/unit/assessment/test_assessment.py | 56 ++++++++++++------------ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/tests/unit/assessment/test_assessment.py b/tests/unit/assessment/test_assessment.py index 8ce40310ec..c94b47f648 100644 --- a/tests/unit/assessment/test_assessment.py +++ b/tests/unit/assessment/test_assessment.py @@ -208,13 +208,13 @@ def test_job_assessment_for_azure_spark_config(): autoscale=AutoScale(min_workers=1, max_workers=6), spark_conf={ "spark.hadoop.fs.azure.account.oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff" - "/sp_app_client_id}}", + "/sp_app_client_id}}", "spark.hadoop.fs.azure.account.oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login" - ".microsoftonline" - ".com/dedededede" - "/token", + ".microsoftonline" + ".com/dedededede" + "/token", "spark.hadoop.fs.azure.account.oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff" - "/sp_secret}}", + "/sp_secret}}", }, spark_context_id=5134472582179566666, spark_env_vars=None, @@ -308,7 +308,7 @@ def test_cluster_assessment(mocker): "oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_app_client_id}}", "spark.hadoop.fs.azure.account." "oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login.microsoftonline.com/dedededede" - "/token", + "/token", "spark.hadoop.fs.azure.account." "oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_secret}}", }, @@ -586,10 +586,10 @@ def test_azure_spn_info_without_secret(mocker): spark_conf={ "spark.hadoop.fs.azure.account.oauth2.client.id.abcde.dfs.core.windows.net": "test123456789", "spark.hadoop.fs.azure.account.oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login" - ".microsoftonline" - ".com/dedededede/token", + ".microsoftonline" + ".com/dedededede/token", "spark.hadoop.fs.azure.account.oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff" - "/sp_secret}}", + "/sp_secret}}", }, spark_context_id=5134472582179565315, spark_env_vars=None, @@ -629,7 +629,7 @@ def test_azure_service_principal_info_crawl(mocker): "oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_app_client_id}}", "spark.hadoop.fs.azure.account." "oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login.microsoftonline.com/dedededede" - "/token", + "/token", "spark.hadoop.fs.azure.account." "oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_secret}}", }, @@ -1355,13 +1355,13 @@ def test_azure_spn_info_with_secret(mocker): autoscale=AutoScale(min_workers=1, max_workers=6), spark_conf={ "spark.hadoop.fs.azure.account.oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff" - "/sp_app_client_id}}", + "/sp_app_client_id}}", "spark.hadoop.fs.azure.account.oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login" - ".microsoftonline" - ".com/dedededede" - "/token", + ".microsoftonline" + ".com/dedededede" + "/token", "spark.hadoop.fs.azure.account.oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff" - "/sp_secret}}", + "/sp_secret}}", }, spark_context_id=5134472582179565315, spark_env_vars=None, @@ -1426,7 +1426,7 @@ def test_list_all_cluster_with_spn_in_spark_conf_with_secret(mocker): "oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_app_client_id}}", "spark.hadoop.fs.azure.account." "oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login.microsoftonline.com/dedededede" - "/token", + "/token", "spark.hadoop.fs.azure.account." "oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_secret}}", }, @@ -1552,7 +1552,7 @@ def test_list_all_clusters_spn_in_spark_conf_with_tenant(mocker): "oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_app_client_id}}", "spark.hadoop.fs.azure.account." "oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login.microsoftonline.com/dummy-tenant" - "-id/oauth2/token", + "-id/oauth2/token", "spark.hadoop.fs.azure.account." "oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_secret}}", }, @@ -1746,13 +1746,13 @@ def test_azure_service_principal_info_dedupe(mocker): spark_conf={ "spark.hadoop.fs.azure.account.auth.type.abcde.dfs.core.windows.net": "OAuth", "spark.hadoop.fs.azure.account.oauth.provider.type.abcde.dfs.core.windows.net": "" - "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider", + "org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider", "spark.hadoop.fs.azure.account.oauth2.client.id.abcde.dfs.core.windows.net": "" - "dummy_application_id", + "dummy_application_id", "spark.hadoop.fs.azure.account.oauth2.client.secret.abcde.dfs.core.windows.net": "" - "ddddddddddddddddddd", + "ddddddddddddddddddd", "spark.hadoop.fs.azure.account.oauth2.client.endpoint.abcde.dfs.core.windows.net": "" - "https://login.microsoftonline.com/dummy_tenant_id/oauth2/token", + "https://login.microsoftonline.com/dummy_tenant_id/oauth2/token", }, ), ), @@ -1842,9 +1842,9 @@ def test_list_all_pipeline_with_conf_spn_in_spark_conf(mocker): ws.pipelines.list_pipelines.return_value = sample_pipelines config_dict = { "spark.hadoop.fs.azure.account.oauth2.client.id.newstorageacct.dfs.core.windows.net": "" - "pipeline_dummy_application_id", + "pipeline_dummy_application_id", "spark.hadoop.fs.azure.account.oauth2.client.endpoint.newstorageacct.dfs.core.windows.net": "" - "https://login.microsoftonline.com/directory_12345/oauth2/token", + "https://login.microsoftonline.com/directory_12345/oauth2/token", "spark.hadoop.fs.azure.sas.fixed.token.abcde.dfs.core.windows.net": "{{secrets/abcde_access/sasFixedToken}}", } ws.pipelines.get().spec.configuration = config_dict @@ -1890,9 +1890,9 @@ def test_list_all_pipeline_with_conf_spn_tenat(mocker): ws.pipelines.list_pipelines.return_value = sample_pipelines config_dict = { "spark.hadoop.fs.azure.account.oauth2.client.id.newstorageacct.dfs.core.windows.net": "" - "pipeline_dummy_application_id", + "pipeline_dummy_application_id", "spark.hadoop.fs.azure1.account.oauth2.client.endpoint.newstorageacct.dfs.core.windows.net": "" - "https://login.microsoftonline.com/directory_12345/oauth2/token", + "https://login.microsoftonline.com/directory_12345/oauth2/token", "spark.hadoop.fs.azure.sas.fixed.token.abcde.dfs.core.windows.net": "{{secrets/abcde_access/sasFixedToken}}", } ws.pipelines.get().spec.configuration = config_dict @@ -1921,7 +1921,7 @@ def test_list_all_pipeline_with_conf_spn_secret(mocker): ".net": "{{secrets/abcde_access/sasFixedToken}}", "spark.hadoop.fs.azure1.account.oauth2.client." "endpoint.newstorageacct.dfs.core.windows.net": "https://" - "login.microsoftonline.com/directory_12345/oauth2/token", + "login.microsoftonline.com/directory_12345/oauth2/token", "spark.hadoop.fs.azure.sas.fixed.token.abcde.dfs.core.windows.net": "{{secrets/abcde_access/sasFixedToken}}", } ws.pipelines.get().spec.configuration = config_dict @@ -2283,7 +2283,7 @@ def test_azure_spn_info_with_secret_unavailable(mocker): "oauth2.client.id.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_app_client_id}}", "spark.hadoop.fs.azure.account." "oauth2.client.endpoint.abcde.dfs.core.windows.net": "https://login.microsoftonline.com/dedededede" - "/token", + "/token", "spark.hadoop.fs.azure.account." "oauth2.client.secret.abcde.dfs.core.windows.net": "{{secrets/abcff/sp_secret}}", } @@ -2310,7 +2310,7 @@ def test_list_all_pipeline_with_conf_spn_secret_unavlbl(mocker): ".net": "{{secrets/reallyreallyasecret/sasFixedToken}}", "spark.hadoop.fs.azure1.account.oauth2.client." "endpoint.newstorageacct.dfs.core.windows.net": "https://" - "login.microsoftonline.com/directory_12345/oauth2/token", + "login.microsoftonline.com/directory_12345/oauth2/token", "spark.hadoop.fs.azure.sas.fixed.token.abcde.dfs.core.windows.net": "{{secrets/abcde_access/sasFixedToken}}", } ws.pipelines.get().spec.configuration = config_dict