Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount point inventorizer #209

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Add mount point inventorizer #209

merged 8 commits into from
Sep 19, 2023

Conversation

william-conti
Copy link
Contributor

Add a Mount Point inventorizer

notebooks/mounts_listing.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/mounts/list_mounts.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/mounts/list_mounts.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/mounts/list_mounts.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/mounts/list_mounts.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/workspace_access/migration.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/workspace_access/migration.py Outdated Show resolved Hide resolved
tests/integration/test_installation.py Outdated Show resolved Hide resolved
tests/integration/test_installation.py Outdated Show resolved Hide resolved
tests/integration/test_installation.py Outdated Show resolved Hide resolved
@william-conti william-conti force-pushed the add_mount_point_inventorizer branch from 4a610ab to 0a30f3a Compare September 18, 2023 21:31
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #209 (6145b5a) into main (c079fb3) will increase coverage by 0.09%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   82.82%   82.91%   +0.09%     
==========================================
  Files          27       28       +1     
  Lines        1572     1598      +26     
  Branches      257      259       +2     
==========================================
+ Hits         1302     1325      +23     
- Misses        229      232       +3     
  Partials       41       41              
Files Changed Coverage Δ
src/databricks/labs/ucx/runtime.py 56.00% <50.00%> (-0.82%) ⬇️
.../databricks/labs/ucx/hive_metastore/list_mounts.py 100.00% <100.00%> (ø)

tests/integration/mounts/test_mounts.py Outdated Show resolved Hide resolved
tests/integration/mounts/test_mounts.py Outdated Show resolved Hide resolved
tests/unit/mounts/test_mounts.py Outdated Show resolved Hide resolved
@william-conti william-conti force-pushed the add_mount_point_inventorizer branch from bf1339c to 6145b5a Compare September 19, 2023 12:42
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nfx nfx added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 4362237 Sep 19, 2023
FastLee pushed a commit that referenced this pull request Sep 19, 2023
Add a Mount Point inventorizer
larsgeorge-db pushed a commit that referenced this pull request Sep 21, 2023
Add a Mount Point inventorizer
@nfx nfx mentioned this pull request Sep 21, 2023
nfx added a commit that referenced this pull request Sep 21, 2023
* Added batched iteration for `INSERT INTO` queries in
`StatementExecutionBackend` with default `max_records_per_batch=1000`
([#237](#237)).
* Added crawler for mount points
([#209](#209)).
* Added crawlers for compatibility of jobs and clusters, along with
basic recommendations for external locations
([#244](#244)).
* Added safe return on grants
([#246](#246)).
* Added ability to specify empty group filter in the installer script
([#216](#216))
([#217](#217)).
* Added ability to install application by multiple different users on
the same workspace ([#235](#235)).
* Added dashboard creation on installation and a requirement for
`warehouse_id` in config, so that the assessment dashboards are
refreshed automatically after job runs
([#214](#214)).
* Added reliance on rate limiting from Databricks SDK for listing
workspace ([#258](#258)).
* Fixed errors in corner cases where Azure Service Principal Credentials
were not available in Spark context
([#254](#254)).
* Fixed `DESCRIBE TABLE` throwing errors when listing Legacy Table ACLs
([#238](#238)).
* Fixed `file already exists` error in the installer script
([#219](#219))
([#222](#222)).
* Fixed `guess_external_locations` failure with `AttributeError:
as_dict` and added an integration test
([#259](#259)).
* Fixed error handling edge cases in `crawl_tables` task
([#243](#243))
([#251](#251)).
* Fixed `crawl_permissions` task failure on folder names containing a
forward slash ([#234](#234)).
* Improved `README` notebook documentation
([#260](#260),
[#228](#228),
[#252](#252),
[#223](#223),
[#225](#225)).
* Removed redundant `.python-version` file
([#221](#221)).
* Removed discovery of account groups from `crawl_permissions` task
([#240](#240)).
* Updated databricks-sdk requirement from ~=0.8.0 to ~=0.9.0
([#245](#245)).
@nfx nfx deleted the add_mount_point_inventorizer branch September 21, 2023 20:58
larsgeorge-db pushed a commit that referenced this pull request Sep 23, 2023
* Added batched iteration for `INSERT INTO` queries in
`StatementExecutionBackend` with default `max_records_per_batch=1000`
([#237](#237)).
* Added crawler for mount points
([#209](#209)).
* Added crawlers for compatibility of jobs and clusters, along with
basic recommendations for external locations
([#244](#244)).
* Added safe return on grants
([#246](#246)).
* Added ability to specify empty group filter in the installer script
([#216](#216))
([#217](#217)).
* Added ability to install application by multiple different users on
the same workspace ([#235](#235)).
* Added dashboard creation on installation and a requirement for
`warehouse_id` in config, so that the assessment dashboards are
refreshed automatically after job runs
([#214](#214)).
* Added reliance on rate limiting from Databricks SDK for listing
workspace ([#258](#258)).
* Fixed errors in corner cases where Azure Service Principal Credentials
were not available in Spark context
([#254](#254)).
* Fixed `DESCRIBE TABLE` throwing errors when listing Legacy Table ACLs
([#238](#238)).
* Fixed `file already exists` error in the installer script
([#219](#219))
([#222](#222)).
* Fixed `guess_external_locations` failure with `AttributeError:
as_dict` and added an integration test
([#259](#259)).
* Fixed error handling edge cases in `crawl_tables` task
([#243](#243))
([#251](#251)).
* Fixed `crawl_permissions` task failure on folder names containing a
forward slash ([#234](#234)).
* Improved `README` notebook documentation
([#260](#260),
[#228](#228),
[#252](#252),
[#223](#223),
[#225](#225)).
* Removed redundant `.python-version` file
([#221](#221)).
* Removed discovery of account groups from `crawl_permissions` task
([#240](#240)).
* Updated databricks-sdk requirement from ~=0.8.0 to ~=0.9.0
([#245](#245)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants