Skip to content

silence conflict samples #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

silence conflict samples #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/receive/writer_errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ func (a *writeErrorTracker) addSampleError(err error, tLogger log.Logger, lset l
a.numSamplesOutOfOrder++
level.Debug(tLogger).Log("msg", "Out of order sample", "lset", lset, "value", v, "timestamp", t)
case errors.Is(err, storage.ErrDuplicateSampleForTimestamp):
a.numSamplesDuplicates++
// we don't consider this is an error
//a.numSamplesDuplicates++
level.Debug(tLogger).Log("msg", "Duplicate sample for timestamp", "lset", lset, "value", v, "timestamp", t)
case errors.Is(err, storage.ErrOutOfBounds):
a.numSamplesOutOfBounds++
Expand All @@ -80,7 +81,7 @@ func (a *writeErrorTracker) addHistogramError(err error, tLogger log.Logger, lse
a.numSamplesOutOfOrder++
level.Debug(tLogger).Log("msg", "Out of order histogram", "lset", lset, "timestamp", timestamp)
case errors.Is(err, storage.ErrDuplicateSampleForTimestamp):
a.numSamplesDuplicates++
//a.numSamplesDuplicates++
level.Debug(tLogger).Log("msg", "Duplicate histogram for timestamp", "lset", lset, "timestamp", timestamp)
case errors.Is(err, storage.ErrOutOfBounds):
a.numSamplesOutOfBounds++
Expand All @@ -103,7 +104,7 @@ func (a *writeErrorTracker) addExemplarError(err error, exLogger log.Logger) {
a.numExemplarsOutOfOrder++
level.Debug(exLogger).Log("msg", "Out of order exemplar")
case errors.Is(err, storage.ErrDuplicateExemplar):
a.numExemplarsDuplicate++
//a.numExemplarsDuplicate++
level.Debug(exLogger).Log("msg", "Duplicate exemplar")
case errors.Is(err, storage.ErrExemplarLabelLength):
a.numExemplarsLabelLength++
Expand Down