Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetime support for min and max functions #2068

Closed
franperezlopez opened this issue Feb 26, 2021 · 5 comments
Closed

datetime support for min and max functions #2068

franperezlopez opened this issue Feb 26, 2021 · 5 comments

Comments

@franperezlopez
Copy link

It looks to me I'm doing something wrong, but I can't find the reason.

image

It seems that when I select the row using min / max functions, an additional hour is added to the date. The same example using pandas works fine. Could you please help me?

@ueshin
Copy link
Collaborator

ueshin commented Mar 3, 2021

Hi @franperezlopez, Thanks for the report!

Actually I couldn't reproduce the behavior in my local, but I had something in mind and submitted a PR #2077.
Could you help test the PR in your end?

@franperezlopez
Copy link
Author

Hi, I'm sorry but I had no time for testing your branch ... did you try updating the local time of your machine? I live in UTC+1 so I presumed the difference was because that

@ueshin
Copy link
Collaborator

ueshin commented Mar 19, 2021

Hi @francopatano, I merged the PR. Could you try with the latest master? Thanks!

@franperezlopez
Copy link
Author

works on my machine 👍

thanks for the fix. keep up the good work!!

@ueshin
Copy link
Collaborator

ueshin commented Mar 19, 2021

Thanks again for the report and confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants