Skip to content

Conversation

@shivam2680
Copy link
Contributor

@shivam2680 shivam2680 commented Aug 26, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Add new session conf to set spark conf to enable metric view metadata

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Tested using custom dbr image. Verified:

  1. cursor.columns() => returns <data_type> measure for measure columns
  2. cursor.tables() => returns METRIC_VIEW for metric views on UC

Related Tickets & Documents

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@shivam2680 shivam2680 requested a review from jprakash-db August 26, 2025 12:52
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@shivam2680 shivam2680 changed the title [PECOBLR-681] added support for measure columns [PECOBLR-681] added new session conf to enable metric view metadata Sep 24, 2025
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@shivam2680 shivam2680 merged commit 54dd646 into main Sep 25, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants