Add test that cursors are closed when connection closes.

Test fails in this commit. Only explicitly indicate that the cursors was
closed server side if we are certain this happened. That is, this attr
must be True _before_ this method was called or as a result of its oper-
ation. Previous behaviour would set the attr=True even if the connection
was already closed, which is not correct.

Signed-off-by: Jesse Whitehouse <[email protected]>

Author: susodapop

src/databricks/sql/client.py

@@ -719,8 +719,8 @@ def close(self) -> None:
                 and self.connection.open
             ):
                 self.thrift_backend.close_command(self.command_id)
+                self.has_been_closed_server_side = True
         finally:
-            self.has_been_closed_server_side = True
             self.op_state = self.thrift_backend.CLOSED_OP_STATE
 
     @staticmethod

tests/e2e/driver_tests.py

@@ -544,6 +544,17 @@ def test_decimal_not_returned_as_strings_arrow(self):
                 decimal_type = arrow_df.field(0).type
                 self.assertTrue(pyarrow.types.is_decimal(decimal_type))
 
+    def test_close_connection_closes_cursors(self):
+        with self.connection() as conn:
+            cursor = conn.cursor()
+            cursor.execute('SELECT id, id `id2`, id `id3` FROM RANGE(1000000) order by RANDOM()')
+            ars = cursor.active_result_set
+            assert not bool(ars.has_been_closed_server_side)
+            conn.close()
+            assert bool(ars.has_been_closed_server_side)
+            cursor.close()
+
+
 
 # use a RetrySuite to encapsulate these tests which we'll typically want to run together; however keep
 # the 429/503 subsuites separate since they execute under different circumstances.