Skip to content

Commit 6a60b30

Browse files
comiusmeisterT
authored andcommitted
Fix coverage support when using default_java_toolchain. (bazelbuild#12801)
* Fix coverage support when using default_java_toolchain. In such case jacoco runner was not set on the java_toolchain. Issue bazelbuild#12793 * Additional coverage test for predefined toolchains. * Revert "Additional coverage test for predefined toolchains." This reverts commit da3f7fd.
1 parent 021576d commit 6a60b30

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

src/test/shell/bazel/bazel_coverage_java_test.sh

+10-1
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ function get_coverage_file_path_from_test_log() {
9999

100100
function test_java_test_coverage() {
101101
cat <<EOF > BUILD
102+
load("//tools/jdk:default_java_toolchain.bzl", "default_java_toolchain")
103+
102104
java_test(
103105
name = "test",
104106
srcs = glob(["src/test/**/*.java"]),
@@ -110,6 +112,10 @@ java_library(
110112
name = "collatz-lib",
111113
srcs = glob(["src/main/**/*.java"]),
112114
)
115+
116+
default_java_toolchain(
117+
name = "custom_toolchain"
118+
)
113119
EOF
114120

115121
mkdir -p src/main/com/example
@@ -179,7 +185,10 @@ LH:5
179185
LF:6
180186
end_of_record"
181187

182-
assert_coverage_result "$expected_result" "$coverage_file_path"
188+
assert_coverage_result "$expected_result" "$coverage_file_path"
189+
190+
bazel coverage --test_output=all --java_toolchain=//:custom_toolchain //:test &>$TEST_log || fail "Coverage with default_java_toolchain for //:test failed"
191+
assert_coverage_result "$expected_result" "$coverage_file_path"
183192
}
184193

185194
function test_java_test_coverage_combined_report() {

tools/jdk/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ remote_java_tools_java_import(
271271
target = ":java_tools/JacocoCoverage_jarjar_deploy.jar",
272272
)
273273

274-
remote_java_tools_java_import(
274+
remote_java_tools_filegroup(
275275
name = "JacocoCoverage",
276276
target = ":java_tools/JacocoCoverage_jarjar_deploy.jar",
277277
)

tools/jdk/default_java_toolchain.bzl

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ DEFAULT_TOOLCHAIN_CONFIGURATION = {
5656
"header_compiler_direct": ["@bazel_tools//tools/jdk:turbine_direct"],
5757
"ijar": ["@bazel_tools//tools/jdk:ijar"],
5858
"javabuilder": ["@bazel_tools//tools/jdk:javabuilder"],
59+
"jacocorunner": "@bazel_tools//tools/jdk:JacocoCoverage",
5960
"tools": [
6061
"@bazel_tools//tools/jdk:javac_jar",
6162
"@bazel_tools//tools/jdk:java_compiler_jar",

0 commit comments

Comments
 (0)