Skip to content

Commit 4b12fc8

Browse files
philwocopybara-github
authored andcommitted
Fix test_source_file_does_not_override_standard_library to work with Python 3.9.
Overloading the "re" module causes weird errors on our new Windows VM image, probably because Python itself uses it for some purpose now. I noticed this in our Bazel CI testing area, so the new image is not yet live. Let's try to use a module that's less core to Python, but still in the standard library - I picked "mailbox" after looking at the list of standard library modules. Here's an example log from the failing test on the new image: ``` ** test_source_file_does_not_override_standard_library ************************* [...] Error processing line 1 of C:\Python3\lib\site-packages\protobuf-3.17.3-py3.9-nspkg.pth: Fatal Python error: init_import_site: Failed to import the site module Python runtime state: initialized Traceback (most recent call last): File "C:\Python3\lib\site.py", line 169, in addpackage exec(line) File "<string>", line 1, in <module> File "C:\Python3\lib\importlib\util.py", line 2, in <module> from . import abc File "C:\Python3\lib\importlib\abc.py", line 17, in <module> from typing import Protocol, runtime_checkable File "C:\Python3\lib\typing.py", line 2203, in <module> Pattern = _alias(stdlib_re.Pattern, 1) AttributeError: module 're' has no attribute 'Pattern' ``` PiperOrigin-RevId: 389572773
1 parent 077cb6f commit 4b12fc8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/shell/bazel/python_version_test.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -531,13 +531,13 @@ py_library(
531531
# (i.e., those implemented in C) use a different loader than
532532
# Python-implemented ones, even though they're both part of the standard
533533
# distribution of the interpreter.
534-
srcs = ["re.py"],
534+
srcs = ["mailbox.py"],
535535
)
536536
EOF
537537
cat > test/main.py << EOF
538-
import re
538+
import mailbox
539539
EOF
540-
cat > test/re.py << EOF
540+
cat > test/mailbox.py << EOF
541541
print("I am lib!")
542542
EOF
543543

0 commit comments

Comments
 (0)