Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is hostname in UserIdentity is fixed to '%' #16570

Open
youngsofun opened this issue Oct 8, 2024 · 3 comments
Open

is hostname in UserIdentity is fixed to '%' #16570

youngsofun opened this issue Oct 8, 2024 · 3 comments

Comments

@youngsofun
Copy link
Member

youngsofun commented Oct 8, 2024

Summary

https://docs.databend.com/sql/sql-commands/ddl/user/user-create-user

if it is, we can

  1. refactor code, e.g. remove the hostname field in UserIdentity.
  2. safely use user_name itself to play the role of UserIdentity in some cases?
@youngsofun youngsofun changed the title is hostname in UserIdentity is fixed to '%' is hostname in UserIdentity is fixed to '%' Oct 8, 2024
@youngsofun
Copy link
Member Author

cc @TCeason @sundy-li

@TCeason
Copy link
Collaborator

TCeason commented Oct 8, 2024

cc @TCeason @sundy-li

#15652 (comment)

@youngsofun
Copy link
Member Author

but seem current sql parse can not accept <user_name>@'<hostname>' at all.

but it seems these users can not be used at all

  1. current sql parse can not accept <user_name>@'<hostname>'
  2. current auth only care about <user_name> too.

maybe we can simple keep some key parser code to not report error when list these old users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants