New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropTableInterpreter should handle error returned from `ctx.get_table()`. #14071

Closed

Tracked by

drmingdrmer opened this issue Dec 18, 2023 · 0 comments

Closed

Tracked by

DropTableInterpreter should handle error returned from `ctx.get_table()`. #14071

drmingdrmer opened this issue Dec 18, 2023 · 0 comments

Assignees

Member

drmingdrmer commented Dec 18, 2023 •

edited

Loading

Result::ok() should not be used. Error need to be dealt with:
https://github.com/datafuselabs/databend/blob/629ee7bab86bf74538814e794122e1fedbbeb288/src/query/service/src/interpreters/interpreter_table_drop.rs#L57-L68

The text was updated successfully, but these errors were encountered:

drmingdrmer mentioned this issue

Tracking issue: Returned error must be dealt carefully. #14064

Closed

3 tasks

drmingdrmer assigned JackTan25 and dantengsky and unassigned JackTan25

JackTan25 mentioned this issue

refactor: refactor error message return for drop table and set options #14078

Merged

11 tasks

drmingdrmer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment