Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spinning more than one dask cluster deletes prior dask task definitions #411

Open
jkanche opened this issue Jul 3, 2023 · 1 comment
Open

spinning more than one dask cluster deletes prior dask task definitions #411

jkanche opened this issue Jul 3, 2023 · 1 comment
Labels
bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS

Comments

@jkanche
Copy link

jkanche commented Jul 3, 2023

when using AWS ECS clusters, spinning up more than one dask cluster deletes the other dask created task definition. I'm guessing its looking up task definitions by tag and removing others?
@jkanche jkanche changed the title spinning more than one dask cluster delete prior dask task definitions spinning more than one dask cluster deletes prior dask task definitions Jul 3, 2023
@jacobtomlinson jacobtomlinson added bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS labels Jul 6, 2023
@jacobtomlinson
Copy link
Member

It should only delete task definitions that aren't associated with any running clusters.

https://github.com/dask/dask-cloudprovider/blob/7b214adc87f1026d8e2149fa109276f6e2497606/dask_cloudprovider/aws/ecs.py#L15790L1585

We define active clusters as clusters with runningTasksCount or pendingTasksCount greater than zero.

Could you share an example of the behaviour you are seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkanche @jacobtomlinson