Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_address_timeout removed: why? #398

Open
dpmccabe opened this issue Jan 20, 2023 · 1 comment
Open

find_address_timeout removed: why? #398

dpmccabe opened this issue Jan 20, 2023 · 1 comment
Labels
needs info Needs further information from the user provider/aws/ecs Cluster provider for AWS ECS question Further information is requested

Comments

@dpmccabe
Copy link

Describe the issue:

The find_address_timeout argument was removed from ecs.Task in 7c84ad7 with no apparent replacement.

Minimal Complete Verifiable Example:

Task(find_address_timeout=180, ...)

Anything else we need to know?:

If specifying this argument is no longer the correct way to prevent timeouts, then what is? That commit did not update any documentation regarding this logic.

@jacobtomlinson jacobtomlinson added question Further information is requested provider/aws/ecs Cluster provider for AWS ECS needs info Needs further information from the user labels Jan 24, 2023
@jacobtomlinson
Copy link
Member

jacobtomlinson commented Jan 24, 2023

This option was removed in #373 because it was no longer needed.

Previously we read the logs until the scheduler address was printed. This could potentially never happen so we added a timeout.

The new implementation uses the ECS API to find the address which always returns a valid address. Therefore we no longer needed a timeout.

It would help if you could share more about the problem you are running into and why you are looking for this timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info Needs further information from the user provider/aws/ecs Cluster provider for AWS ECS question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants