Skip to content

sync: main to datafusion-sql-planner #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 3 commits into from
Sep 14, 2022
Merged

sync: main to datafusion-sql-planner #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bab536
Set pytest to fail on xpassing tests (#756)
charlesbluca Sep 13, 2022
4a133f2
Merge branch 'datafusion-sql-planner' into merge-upstream-main
charlesbluca Sep 13, 2022
4d44ffb
Resolve xpassing queries
charlesbluca Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ testpaths =
markers =
gpu: marks tests that require GPUs (skipped by default, run with '--rungpu')
queries: marks tests that run test queries (skipped by default, run with '--runqueries')
xfail_strict=true
5 changes: 1 addition & 4 deletions tests/integration/test_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,7 @@ def test_create_from_query(c, df):
False,
pytest.param(
True,
marks=(
pytest.mark.gpu,
pytest.mark.xfail(reason="to_pandas() changes int precision"),
),
marks=pytest.mark.gpu,
),
],
)
Expand Down
5 changes: 0 additions & 5 deletions tests/integration/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import os
import pickle
import sys

import joblib
import pandas as pd
Expand Down Expand Up @@ -576,10 +575,6 @@ def test_mlflow_export(c, training_df, tmpdir):


# TODO - many ML tests fail on clusters without sklearn - can we avoid this?
@pytest.mark.xfail(
sys.platform == "win32",
reason="Windows is not officially supported for dask/xgboost",
)
@skip_if_external_scheduler
def test_mlflow_export_xgboost(c, client, training_df, tmpdir):
# Test only when mlflow & xgboost was installed
Expand Down
5 changes: 0 additions & 5 deletions tests/unit/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import pytest

XFAIL_QUERIES = (
2,
4,
5,
6,
Expand All @@ -15,7 +14,6 @@
13,
14,
16,
17,
18,
20,
21,
Expand All @@ -32,7 +30,6 @@
39,
40,
41,
43,
44,
45,
47,
Expand All @@ -45,7 +42,6 @@
58,
59,
62,
64,
66,
67,
69,
Expand All @@ -54,7 +50,6 @@
73,
74,
75,
76,
77,
78,
80,
Expand Down