Skip to content

Conversation

@lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 18, 2025

Issue being fixed or feature implemented

There are some minor changes in 2.1.3 that are not in v2.2.

What was done?

Merged changes, solved conflicts in favor of v2.2.

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Bug Fixes

    • Drive now reuses existing platform node IDs during operator identity updates.
  • Documentation

    • Reformatted platform services tables for clearer presentation.
    • Added changelog entry for version 2.1.3 (2025-10-29).
  • Chores / Refactor

    • Standardized end-of-file/formatting cleanups across package manifests.
    • Added an option to control which platform-related configuration profiles are included.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "7c0b3f80489dad320999620c25154ea610ecd80db53ef6b6f3701800e3590a41"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Fix operator identity update to reuse an existing platform node ID and add a test; change dashmate getConfigProfiles to accept an options parameter altering profile selection; reformat platform docs table; move Cargo.toml edition line; and normalize EOF newlines across many package.json files.

Changes

Cohort / File(s) Change Summary
Bug Fix & Test
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs
Construct platform_node_id key data from new_platform_node_id instead of platform_node_id_change.to_vec(); add test test_update_operator_identity_reuses_node_id_without_change verifying reuse of existing node ID in AddNewKeysToIdentity.
Dashmate config API
packages/dashmate/src/config/getConfigProfilesFactory.js
Update getConfigProfiles signature to getConfigProfiles(config, { includeAll = false } = {}); adjust logic to add platform-dapi-deprecated and/or platform-dapi-rs based on includeAll and platform.dapi.deprecated.enabled.
Changelog
CHANGELOG.md
Add v2.1.3 (2025-10-29) entry documenting: "Bug Fix: drive reuses existing platform node id during operator update (#2834)".
Documentation
packages/dashmate/docs/services/platform.md
Reformat platform services / rs-dapi ports tables into a compact single-table layout; no content changes.
Cargo metadata
packages/rs-dash-event-bus/Cargo.toml
Move edition = "2024" to appear directly under [package]; semantic metadata unchanged.
Formatting — EOF newlines
Multiple package.json files
package.json, packages/{bench-suite,dapi-grpc,dapi,dash-spv,dashmate,dashpay-contract,dpns-contract,feature-flags-contract,js-dapi-client,js-dash-sdk,js-evo-sdk,js-grpc-common,keyword-search-contract,masternode-reward-shares-contract,platform-test-suite,token-history-contract,wallet-lib,wallet-utils-contract,wasm-dpp,wasm-drive-verify,wasm-sdk,withdrawals-contract}/package.json
Normalize trailing newline presence at EOF across many package.json files; no functional, dependency, script, or API changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

  • Pay attention to:
    • packages/rs-drive-abci/.../mod.rs — ensure new_platform_node_id is used correctly across code paths and serialized format matches Drive expectations.
    • The new test test_update_operator_identity_reuses_node_id_without_change — confirm setup, pre-population of platform state, and assertions adequately cover edge cases.
    • packages/dashmate/src/config/getConfigProfilesFactory.js — verify callers handle the new optional parameter and intended profile selection.

Poem

🐇 I tuck an ID back in its lair,
I hop through code and tidy a chair,
Docs line up, Cargo finds its place,
EOFs settle with gentle grace,
A tiny test, a clear-faced trace.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: backport v2.1.3 into v2.2' clearly describes the main purpose of the PR: backporting changes from version 2.1.3 into the v2.2 branch, which aligns with the actual changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae65e84 and 5fce558.

📒 Files selected for processing (24)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
  • packages/bench-suite/package.json (1 hunks)
  • packages/dapi-grpc/package.json (1 hunks)
  • packages/dapi/package.json (1 hunks)
  • packages/dash-spv/package.json (1 hunks)
  • packages/dashmate/package.json (1 hunks)
  • packages/dashpay-contract/package.json (1 hunks)
  • packages/dpns-contract/package.json (1 hunks)
  • packages/feature-flags-contract/package.json (1 hunks)
  • packages/js-dapi-client/package.json (1 hunks)
  • packages/js-dash-sdk/package.json (1 hunks)
  • packages/js-evo-sdk/package.json (1 hunks)
  • packages/js-grpc-common/package.json (1 hunks)
  • packages/keyword-search-contract/package.json (1 hunks)
  • packages/masternode-reward-shares-contract/package.json (1 hunks)
  • packages/platform-test-suite/package.json (1 hunks)
  • packages/token-history-contract/package.json (1 hunks)
  • packages/wallet-lib/package.json (1 hunks)
  • packages/wallet-utils-contract/package.json (1 hunks)
  • packages/wasm-dpp/package.json (1 hunks)
  • packages/wasm-drive-verify/package.json (1 hunks)
  • packages/wasm-sdk/package.json (1 hunks)
  • packages/withdrawals-contract/package.json (1 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

shumkov
shumkov previously approved these changes Nov 28, 2025
@lklimek lklimek merged commit bc2dd30 into v2.2-dev Nov 28, 2025
107 of 108 checks passed
@lklimek lklimek deleted the backport/2.1.3 branch November 28, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants