DIP 22: Deterministic InstantSend #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
commented
Aug 3, 2021
Collaborator
Author
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
A couple questions for @QuantumExplorer and @UdjinM6
thephez
commented
Oct 7, 2021
thephez
commented
Oct 7, 2021
VirgileBa
reviewed
Oct 7, 2021
deterministic-instantsend.md
Outdated
| 3. For each LLMQ of this quorum cycle’s set, calculate `SHA256(quorumType, quorumHash, requestId)` | ||
| 4. Sort the list of LLMQs based on the result of step 3 in ascending order | ||
| 5. Use the first entry of the sorted list as the responsible LLMQ | ||
| 6. Create the SignID by calculating `SHA256(quorumHash, requestId, SHA256(version, txHash))` |
Collaborator
There was a problem hiding this comment.
Suggested change
| 6. Create the SignID by calculating `SHA256(quorumHash, requestId, SHA256(version, txHash))` | |
| 6. Create the SignID by calculating `SHA256(quorumHash, requestId)` |
thephez
commented
Oct 7, 2021
thephez
force-pushed
the
deterministic-instantsend
branch
from
cdc11a3 to
bc36b71
Compare
gabriel-bjg
reviewed
Oct 11, 2021
Co-authored-by: gabriel-bjg <[email protected]>
thephez
changed the title
Collaborator
Author
|
@PastaPastaPasta @QuantumExplorer @UdjinM6 Please complete a final review on this so we can merge it. 🙏 |
UdjinM6
previously approved these changes
Oct 21, 2021
UdjinM6
approved these changes
Oct 21, 2021
Collaborator
Author
@PastaPastaPasta @QuantumExplorer Please complete a final review on this so we can merge it. 🙏 |
PastaPastaPasta
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DIP aims to improve InstantSend messages to make them deterministically verifiable.
Link to doc: https://github.com/dashpay/dips/blob/deterministic-instantsend/dip-0022.md
Thanks to @QuantumExplorer and @UdjinM6 for collaborating on this