Skip to content

fix(rpc)!: require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix(rpc)!: require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc #5772

wants to merge 3 commits into from

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 17, 2023 •
edited
Loading

Issue being fixed or feature implemented

Because when we ask for a quorum wide data only (QUORUM_VERIFICATION_VECTOR) and not for a data about one specific MN proTxHash is not used in any way in this case and should not be provided. If it still was provided then maybe user doesn't quite understand what he is doing exactly or maybe he made a typo in dataMask.

What was done?

How Has This Been Tested?

Breaking Changes

quorum getdata RPC will no longer allow proTxHash to be specified when dataMask is set to 1.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 21 milestone Dec 17, 2023
@UdjinM6 UdjinM6 mentioned this pull request Dec 17, 2023
Merged
5 tasks
@UdjinM6 UdjinM6 changed the title rpc: require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc fix(rpc): require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc Dec 17, 2023
@UdjinM6 UdjinM6 changed the title fix(rpc): require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc fix(rpc)!: require proTxHash to be unspecified when not asking for ENCRYPTED_CONTRIBUTIONS in quorum getdata rpc Dec 17, 2023
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Dec 17, 2023

Release notes + add text to "Breaking changes" section of pr?

ogabrielides
ogabrielides previously approved these changes Dec 17, 2023
View reviewed changes
Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Dec 18, 2023
ogabrielides
ogabrielides previously approved these changes Dec 18, 2023
View reviewed changes
Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

knst
knst reviewed Dec 22, 2023
View reviewed changes
src/rpc/quorums.cpp
}
} else if (!request.params[4].isNull()) {
// Require no proTxHash otherwise
throw JSONRPCError(RPC_INVALID_PARAMETER, "Should not specify proTxHash");
Copy link
Collaborator

@knst knst Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it easy to make functional test for this case? 🤔

ogabrielides
ogabrielides previously approved these changes Dec 27, 2023
View reviewed changes
Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

knst
knst previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review when we branch of v21

@UdjinM6 UdjinM6 marked this pull request as draft February 13, 2024 08:29
@UdjinM6 UdjinM6 removed this from the 21 milestone Jul 26, 2024
@UdjinM6 UdjinM6 dismissed stale reviews from knst and ogabrielides via db09b6b August 8, 2024 21:34
@UdjinM6 UdjinM6 added this to the 22 milestone Aug 8, 2024
@UdjinM6 UdjinM6 force-pushed the require_no_protx branch 2 times, most recently from f635cd7 to 00a176f Compare August 13, 2024 15:18
@UdjinM6 UdjinM6 marked this pull request as ready for review September 22, 2024 17:17
knst
knst previously approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f18b4e8

The new test fails without changes in rpc/quorums.cpp indeed as expected

@PastaPastaPasta PastaPastaPasta modified the milestones: 22, 22.1 Nov 14, 2024
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Nov 14, 2024

Anything blocking this? or should we merge it?

@PastaPastaPasta PastaPastaPasta self-requested a review November 14, 2024 17:29
@UdjinM6 UdjinM6 modified the milestones: 22.1, 23 Nov 17, 2024
@UdjinM6 UdjinM6 marked this pull request as draft December 11, 2024 15:07
@DashCoreAutoGuix
Copy link

DashCoreAutoGuix commented Jul 28, 2025

ℹ️ Not a Bitcoin Backport

This PR is not a Bitcoin backport - it implements Dash-specific quorum functionality that doesn't exist in Bitcoin.

Original Bitcoin commit: N/A (Dash-specific feature)
Reviewed commit hash: f18b4e8ca9-verify-1753723480

Analysis Summary:

  • ✅ CI Status: All 33 checks passing
  • ✅ Release Notes: Present and appropriate (doc/release-notes-5772.md)
  • ✅ Breaking Changes: Properly documented in PR description
  • ✅ Code Quality: Implements proper input validation for quorum RPC
  • ✅ Tests: Includes functional test coverage

Reviewer Feedback Addressed:

  • Issue from @PastaPastaPasta: Release notes → ✅ Added in doc/release-notes-5772.md
  • Issue from @PastaPastaPasta: Breaking changes documentation → ✅ Present in PR description

This PR enhances the quorum getdata RPC by requiring proTxHash to be unspecified when requesting quorum-wide data (dataMask=1), preventing user confusion and potential mistakes.

Recommendation: This PR is ready for merge as a Dash-specific enhancement.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@UdjinM6 UdjinM6 removed this from the 23 milestone Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst left review comments

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

+1 more reviewer

@ogabrielides ogabrielides ogabrielides left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@UdjinM6 @PastaPastaPasta @DashCoreAutoGuix @ogabrielides @knst @thephez