ci: more checksums in guix workflow #5417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also group and sort them
PastaPastaPasta
previously approved these changes
Jun 8, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
kwvg
reviewed
Jun 8, 2023
kwvg
approved these changes
Jun 9, 2023
Collaborator
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
CI failure unrelated to changes made, utACK
PastaPastaPasta
approved these changes
Jun 9, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
knst
pushed a commit
to knst/dash
that referenced
this pull request
Jun 22, 2023
## Issue being fixed or feature implemented 1. not all binaries were covered with checksums 2. there were no checksums for archives ## What was done? add missing checksums, also group and sort them ## How Has This Been Tested? run commands after local guix build see this PR results ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
add missing checksums, also group and sort them
How Has This Been Tested?
run commands after local guix build
see this PR results
Breaking Changes
n/a
Checklist: