From 2de58589f4299546674cda1f188c794ffc0d5743 Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kittywhiskers@users.noreply.github.com> Date: Fri, 1 Oct 2021 22:59:13 +0530 Subject: [PATCH 1/4] refactor: coinjoin/coinjoin-*[cpp/h] --> coinjoin/*.[cpp/h] --- src/Makefile.am | 18 +++++++++--------- .../{coinjoin-client.cpp => client.cpp} | 4 ++-- src/coinjoin/{coinjoin-client.h => client.h} | 8 ++++---- ...coinjoin-client-options.cpp => options.cpp} | 2 +- .../{coinjoin-client-options.h => options.h} | 6 +++--- .../{coinjoin-server.cpp => server.cpp} | 2 +- src/coinjoin/{coinjoin-server.h => server.h} | 6 +++--- src/coinjoin/{coinjoin-util.cpp => util.cpp} | 2 +- src/coinjoin/{coinjoin-util.h => util.h} | 6 +++--- src/dsnotificationinterface.cpp | 2 +- src/init.cpp | 2 +- src/interfaces/node.cpp | 2 +- src/interfaces/wallet.cpp | 2 +- src/masternode/masternode-utils.cpp | 2 +- src/net_processing.cpp | 4 ++-- src/qt/optionsmodel.cpp | 2 +- src/qt/overviewpage.cpp | 2 +- src/qt/test/wallettests.cpp | 2 +- src/rpc/coinjoin.cpp | 6 +++--- src/wallet/init.cpp | 4 ++-- src/wallet/rpcwallet.cpp | 4 ++-- src/wallet/test/coinjoin_tests.cpp | 2 +- src/wallet/wallet.cpp | 4 ++-- test/lint/lint-circular-dependencies.sh | 6 +++--- 24 files changed, 50 insertions(+), 50 deletions(-) rename src/coinjoin/{coinjoin-client.cpp => client.cpp} (99%) rename src/coinjoin/{coinjoin-client.h => client.h} (97%) rename src/coinjoin/{coinjoin-client-options.cpp => options.cpp} (98%) rename src/coinjoin/{coinjoin-client-options.h => options.h} (96%) rename src/coinjoin/{coinjoin-server.cpp => server.cpp} (99%) rename src/coinjoin/{coinjoin-server.h => server.h} (96%) rename src/coinjoin/{coinjoin-util.cpp => util.cpp} (99%) rename src/coinjoin/{coinjoin-util.h => util.h} (98%) diff --git a/src/Makefile.am b/src/Makefile.am index f49ff598da00..d875f559dcfd 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -137,10 +137,10 @@ BITCOIN_CORE_H = \ checkqueue.h \ clientversion.h \ coinjoin/coinjoin.h \ - coinjoin/coinjoin-client.h \ - coinjoin/coinjoin-client-options.h \ - coinjoin/coinjoin-server.h \ - coinjoin/coinjoin-util.h \ + coinjoin/client.h \ + coinjoin/options.h \ + coinjoin/server.h \ + coinjoin/util.h \ coins.h \ compat.h \ compat/assumptions.h \ @@ -329,8 +329,8 @@ libdash_server_a_SOURCES = \ chain.cpp \ checkpoints.cpp \ coinjoin/coinjoin.cpp \ - coinjoin/coinjoin-client-options.cpp \ - coinjoin/coinjoin-server.cpp \ + coinjoin/options.cpp \ + coinjoin/server.cpp \ consensus/tx_verify.cpp \ dsnotificationinterface.cpp \ evo/cbtx.cpp \ @@ -437,9 +437,9 @@ endif libdash_wallet_a_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) libdash_wallet_a_CXXFLAGS = $(AM_CXXFLAGS) $(PIE_FLAGS) libdash_wallet_a_SOURCES = \ - coinjoin/coinjoin-client.cpp \ - coinjoin/coinjoin-client-options.cpp \ - coinjoin/coinjoin-util.cpp \ + coinjoin/client.cpp \ + coinjoin/options.cpp \ + coinjoin/util.cpp \ interfaces/wallet.cpp \ keepass.cpp \ wallet/coincontrol.cpp \ diff --git a/src/coinjoin/coinjoin-client.cpp b/src/coinjoin/client.cpp similarity index 99% rename from src/coinjoin/coinjoin-client.cpp rename to src/coinjoin/client.cpp index fda138da9782..3488d1dd2ed2 100644 --- a/src/coinjoin/coinjoin-client.cpp +++ b/src/coinjoin/client.cpp @@ -2,8 +2,8 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include -#include +#include +#include #include #include diff --git a/src/coinjoin/coinjoin-client.h b/src/coinjoin/client.h similarity index 97% rename from src/coinjoin/coinjoin-client.h rename to src/coinjoin/client.h index c9d29429a63b..1dc97ad896b6 100644 --- a/src/coinjoin/coinjoin-client.h +++ b/src/coinjoin/client.h @@ -2,10 +2,10 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_COINJOIN_COINJOIN_CLIENT_H -#define BITCOIN_COINJOIN_COINJOIN_CLIENT_H +#ifndef BITCOIN_COINJOIN_CLIENT_H +#define BITCOIN_COINJOIN_CLIENT_H -#include +#include #include #include @@ -252,4 +252,4 @@ class CCoinJoinClientManager void DoCoinJoinMaintenance(CConnman& connman); -#endif // BITCOIN_COINJOIN_COINJOIN_CLIENT_H +#endif // BITCOIN_COINJOIN_CLIENT_H diff --git a/src/coinjoin/coinjoin-client-options.cpp b/src/coinjoin/options.cpp similarity index 98% rename from src/coinjoin/coinjoin-client-options.cpp rename to src/coinjoin/options.cpp index 74aff83b1133..970df24ab564 100644 --- a/src/coinjoin/coinjoin-client-options.cpp +++ b/src/coinjoin/options.cpp @@ -2,7 +2,7 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include +#include #include #include diff --git a/src/coinjoin/coinjoin-client-options.h b/src/coinjoin/options.h similarity index 96% rename from src/coinjoin/coinjoin-client-options.h rename to src/coinjoin/options.h index e87ef0c20b08..6b022778c6e9 100644 --- a/src/coinjoin/coinjoin-client-options.h +++ b/src/coinjoin/options.h @@ -2,8 +2,8 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_COINJOIN_COINJOIN_CLIENT_OPTIONS_H -#define BITCOIN_COINJOIN_COINJOIN_CLIENT_OPTIONS_H +#ifndef BITCOIN_COINJOIN_OPTIONS_H +#define BITCOIN_COINJOIN_OPTIONS_H #include #include @@ -91,4 +91,4 @@ class CCoinJoinClientOptions static void Init(); }; -#endif // BITCOIN_COINJOIN_COINJOIN_CLIENT_OPTIONS_H +#endif // BITCOIN_COINJOIN_OPTIONS_H diff --git a/src/coinjoin/coinjoin-server.cpp b/src/coinjoin/server.cpp similarity index 99% rename from src/coinjoin/coinjoin-server.cpp rename to src/coinjoin/server.cpp index e07264173b41..5d20d4943ea8 100644 --- a/src/coinjoin/coinjoin-server.cpp +++ b/src/coinjoin/server.cpp @@ -2,7 +2,7 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include +#include #include #include diff --git a/src/coinjoin/coinjoin-server.h b/src/coinjoin/server.h similarity index 96% rename from src/coinjoin/coinjoin-server.h rename to src/coinjoin/server.h index 2887cbc501b8..f9fb346d4b1a 100644 --- a/src/coinjoin/coinjoin-server.h +++ b/src/coinjoin/server.h @@ -2,8 +2,8 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_COINJOIN_COINJOIN_SERVER_H -#define BITCOIN_COINJOIN_COINJOIN_SERVER_H +#ifndef BITCOIN_COINJOIN_SERVER_H +#define BITCOIN_COINJOIN_SERVER_H #include #include @@ -87,4 +87,4 @@ class CCoinJoinServer : public CCoinJoinBaseSession, public CCoinJoinBaseManager void GetJsonInfo(UniValue& obj) const; }; -#endif // BITCOIN_COINJOIN_COINJOIN_SERVER_H +#endif // BITCOIN_COINJOIN_SERVER_H diff --git a/src/coinjoin/coinjoin-util.cpp b/src/coinjoin/util.cpp similarity index 99% rename from src/coinjoin/coinjoin-util.cpp rename to src/coinjoin/util.cpp index c1de05b057d4..c589b1fdd45e 100644 --- a/src/coinjoin/coinjoin-util.cpp +++ b/src/coinjoin/util.cpp @@ -2,7 +2,7 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include +#include #include #include #include diff --git a/src/coinjoin/coinjoin-util.h b/src/coinjoin/util.h similarity index 98% rename from src/coinjoin/coinjoin-util.h rename to src/coinjoin/util.h index 743b6ff27249..debdc3dfd0b5 100644 --- a/src/coinjoin/coinjoin-util.h +++ b/src/coinjoin/util.h @@ -2,8 +2,8 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_COINJOIN_COINJOIN_UTIL_H -#define BITCOIN_COINJOIN_COINJOIN_UTIL_H +#ifndef BITCOIN_COINJOIN_UTIL_H +#define BITCOIN_COINJOIN_UTIL_H #include @@ -137,4 +137,4 @@ class CTransactionBuilder int GetSizeOfCompactSizeDiff(size_t nAdd) const; }; -#endif // BITCOIN_COINJOIN_COINJOIN_UTIL_H +#endif // BITCOIN_COINJOIN_UTIL_H diff --git a/src/dsnotificationinterface.cpp b/src/dsnotificationinterface.cpp index ac1caf4a4309..37c9f4c3709c 100644 --- a/src/dsnotificationinterface.cpp +++ b/src/dsnotificationinterface.cpp @@ -5,7 +5,7 @@ #include #include #ifdef ENABLE_WALLET -#include +#include #endif // ENABLE_WALLET #include #include diff --git a/src/init.cpp b/src/init.cpp index 0e505404aa8a..73e0f4002750 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -58,7 +58,7 @@ #include #include -#include +#include #include #include #include diff --git a/src/interfaces/node.cpp b/src/interfaces/node.cpp index c7b3f7d4ac7b..8ce5ac757a48 100644 --- a/src/interfaces/node.cpp +++ b/src/interfaces/node.cpp @@ -39,7 +39,7 @@ #endif #include -#include +#include #include #include diff --git a/src/interfaces/wallet.cpp b/src/interfaces/wallet.cpp index 745b9e6d7b7d..5077cbf710a6 100644 --- a/src/interfaces/wallet.cpp +++ b/src/interfaces/wallet.cpp @@ -6,7 +6,7 @@ #include #include -#include +#include #include #include #include diff --git a/src/masternode/masternode-utils.cpp b/src/masternode/masternode-utils.cpp index f969fedf8feb..648b499091d4 100644 --- a/src/masternode/masternode-utils.cpp +++ b/src/masternode/masternode-utils.cpp @@ -6,7 +6,7 @@ #include #ifdef ENABLE_WALLET -#include +#include #endif #include #include diff --git a/src/net_processing.cpp b/src/net_processing.cpp index f8226d35fd74..ba267bf40e92 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -44,9 +44,9 @@ #include #include #ifdef ENABLE_WALLET -#include +#include #endif // ENABLE_WALLET -#include +#include #include #include diff --git a/src/qt/optionsmodel.cpp b/src/qt/optionsmodel.cpp index 88c65cdf5a0c..a3b5a1e3bdde 100644 --- a/src/qt/optionsmodel.cpp +++ b/src/qt/optionsmodel.cpp @@ -20,7 +20,7 @@ #include // for -dbcache defaults #ifdef ENABLE_WALLET -#include +#include #endif #include diff --git a/src/qt/overviewpage.cpp b/src/qt/overviewpage.cpp index 481546c72e03..36cd3c40340f 100644 --- a/src/qt/overviewpage.cpp +++ b/src/qt/overviewpage.cpp @@ -15,7 +15,7 @@ #include #include -#include +#include #include #include diff --git a/src/qt/test/wallettests.cpp b/src/qt/test/wallettests.cpp index 32a2678184b5..973f05ceaef3 100644 --- a/src/qt/test/wallettests.cpp +++ b/src/qt/test/wallettests.cpp @@ -1,7 +1,7 @@ #include #include -#include +#include #include #include #include diff --git a/src/rpc/coinjoin.cpp b/src/rpc/coinjoin.cpp index bccf9315fe21..4eed603763f4 100644 --- a/src/rpc/coinjoin.cpp +++ b/src/rpc/coinjoin.cpp @@ -4,11 +4,11 @@ #include #ifdef ENABLE_WALLET -#include -#include +#include +#include #include #endif // ENABLE_WALLET -#include +#include #include #include diff --git a/src/wallet/init.cpp b/src/wallet/init.cpp index 4a443b41a805..d695829a65c4 100644 --- a/src/wallet/init.cpp +++ b/src/wallet/init.cpp @@ -16,8 +16,8 @@ #include #include -#include -#include +#include +#include #include diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index 507653df5453..e8a6f7fcee7f 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -34,8 +34,8 @@ #include #include -#include -#include +#include +#include #include #include diff --git a/src/wallet/test/coinjoin_tests.cpp b/src/wallet/test/coinjoin_tests.cpp index 807adbbc446a..73e8d73fa770 100644 --- a/src/wallet/test/coinjoin_tests.cpp +++ b/src/wallet/test/coinjoin_tests.cpp @@ -5,7 +5,7 @@ #include #include -#include +#include #include #include #include diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index be4d1d5abcbc..a45d240b7e87 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include #include #include diff --git a/test/lint/lint-circular-dependencies.sh b/test/lint/lint-circular-dependencies.sh index 8dc85c2a1727..86b0c0b04512 100755 --- a/test/lint/lint-circular-dependencies.sh +++ b/test/lint/lint-circular-dependencies.sh @@ -36,7 +36,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES=( "qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/signverifymessagedialog -> qt/addressbookpage" "qt/addressbookpage -> qt/bitcoingui -> qt/walletview -> qt/sendcoinsdialog -> qt/sendcoinsentry -> qt/addressbookpage" # Dash - "coinjoin/coinjoin-server -> net_processing -> coinjoin/coinjoin-server" + "coinjoin/server -> net_processing -> coinjoin/server" "evo/cbtx -> evo/simplifiedmns -> evo/cbtx" "evo/cbtx -> evo/specialtx -> evo/cbtx" "evo/deterministicmns -> evo/providertx -> evo/deterministicmns" @@ -82,7 +82,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES=( "logging -> util/system -> random -> logging" "logging -> util/system -> sync -> logging" "logging -> util/system -> stacktraces -> logging" - "coinjoin/coinjoin-client -> coinjoin/coinjoin-util -> wallet/wallet -> coinjoin/coinjoin-client" + "coinjoin/client -> coinjoin/util -> wallet/wallet -> coinjoin/client" "qt/appearancewidget -> qt/guiutil -> qt/optionsdialog -> qt/appearancewidget" "qt/bitcoinaddressvalidator -> qt/guiutil -> qt/qvalidatedlineedit -> qt/bitcoinaddressvalidator" "qt/guiutil -> qt/optionsdialog -> qt/optionsmodel -> qt/guiutil" @@ -93,7 +93,7 @@ EXPECTED_CIRCULAR_DEPENDENCIES=( "evo/specialtx -> llmq/quorums_blockprocessor -> net_processing -> txmempool -> evo/specialtx" "evo/providertx -> evo/specialtx -> llmq/quorums_blockprocessor -> net_processing -> txmempool -> evo/providertx" - "coinjoin/coinjoin-client -> net_processing -> coinjoin/coinjoin-client" + "coinjoin/client -> net_processing -> coinjoin/client" "llmq/quorums -> net_processing -> llmq/quorums" "llmq/quorums_commitment -> llmq/quorums_utils -> llmq/quorums_commitment" "llmq/quorums_dkgsession -> llmq/quorums_dkgsessionmgr -> llmq/quorums_dkgsession" From e92dad394e1ac06df60c480a3e31d89db3a9ac00 Mon Sep 17 00:00:00 2001 From: Kittywhiskers Van Gogh <63189531+kittywhiskers@users.noreply.github.com> Date: Fri, 1 Oct 2021 23:20:54 +0530 Subject: [PATCH 2/4] refactor: governance/governance-*[cpp/h] --> governance/*.[cpp/h] --- src/Makefile.am | 22 +++++++++---------- .../{governance-classes.cpp => classes.cpp} | 2 +- .../{governance-classes.h => classes.h} | 8 +++---- .../{governance-exceptions.h => exceptions.h} | 6 ++--- src/governance/governance.cpp | 4 ++-- src/governance/governance.h | 2 +- .../{governance-object.cpp => object.cpp} | 4 ++-- .../{governance-object.h => object.h} | 12 +++++----- ...vernance-validators.cpp => validators.cpp} | 4 ++-- .../{governance-validators.h => validators.h} | 6 ++--- .../{governance-vote.cpp => vote.cpp} | 2 +- src/governance/{governance-vote.h => vote.h} | 6 ++--- .../{governance-votedb.cpp => votedb.cpp} | 2 +- .../{governance-votedb.h => votedb.h} | 8 +++---- src/interfaces/node.cpp | 2 +- src/masternode/masternode-payments.cpp | 2 +- src/rpc/governance.cpp | 6 ++--- src/rpc/masternode.cpp | 2 +- src/rpc/mining.cpp | 2 +- src/test/governance_validators_tests.cpp | 2 +- src/wallet/wallet.h | 2 +- src/wallet/walletdb.cpp | 2 +- src/zmq/zmqpublishnotifier.cpp | 4 ++-- test/lint/lint-circular-dependencies.sh | 14 ++++++------ 24 files changed, 63 insertions(+), 63 deletions(-) rename src/governance/{governance-classes.cpp => classes.cpp} (99%) rename src/governance/{governance-classes.h => classes.h} (94%) rename src/governance/{governance-exceptions.h => exceptions.h} (94%) rename src/governance/{governance-object.cpp => object.cpp} (99%) rename src/governance/{governance-object.h => object.h} (97%) rename src/governance/{governance-validators.cpp => validators.cpp} (99%) rename src/governance/{governance-validators.h => validators.h} (88%) rename src/governance/{governance-vote.cpp => vote.cpp} (99%) rename src/governance/{governance-vote.h => vote.h} (96%) rename src/governance/{governance-votedb.cpp => votedb.cpp} (98%) rename src/governance/{governance-votedb.h => votedb.h} (91%) diff --git a/src/Makefile.am b/src/Makefile.am index d875f559dcfd..3b49ea0572c6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -164,12 +164,12 @@ BITCOIN_CORE_H = \ evo/specialtx.h \ dsnotificationinterface.h \ governance/governance.h \ - governance/governance-classes.h \ - governance/governance-exceptions.h \ - governance/governance-object.h \ - governance/governance-validators.h \ - governance/governance-vote.h \ - governance/governance-votedb.h \ + governance/classes.h \ + governance/exceptions.h \ + governance/object.h \ + governance/validators.h \ + governance/vote.h \ + governance/votedb.h \ flat-database.h \ hdchain.h \ flatfile.h \ @@ -351,11 +351,11 @@ libdash_server_a_SOURCES = \ init.cpp \ dbwrapper.cpp \ governance/governance.cpp \ - governance/governance-classes.cpp \ - governance/governance-object.cpp \ - governance/governance-validators.cpp \ - governance/governance-vote.cpp \ - governance/governance-votedb.cpp \ + governance/classes.cpp \ + governance/object.cpp \ + governance/validators.cpp \ + governance/vote.cpp \ + governance/votedb.cpp \ llmq/quorums.cpp \ llmq/quorums_blockprocessor.cpp \ llmq/quorums_commitment.cpp \ diff --git a/src/governance/governance-classes.cpp b/src/governance/classes.cpp similarity index 99% rename from src/governance/governance-classes.cpp rename to src/governance/classes.cpp index 3985dac8581c..97e4be6fdd53 100644 --- a/src/governance/governance-classes.cpp +++ b/src/governance/classes.cpp @@ -2,7 +2,7 @@ // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include +#include #include #include diff --git a/src/governance/governance-classes.h b/src/governance/classes.h similarity index 94% rename from src/governance/governance-classes.h rename to src/governance/classes.h index 70eec7c273cd..601c2a6471e9 100644 --- a/src/governance/governance-classes.h +++ b/src/governance/classes.h @@ -1,11 +1,11 @@ // Copyright (c) 2014-2021 The Dash Core developers // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#ifndef BITCOIN_GOVERNANCE_GOVERNANCE_CLASSES_H -#define BITCOIN_GOVERNANCE_GOVERNANCE_CLASSES_H +#ifndef BITCOIN_GOVERNANCE_CLASSES_H +#define BITCOIN_GOVERNANCE_CLASSES_H #include -#include +#include #include