Add support for Gitlab CI #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_gitlabci
branch
3 times, most recently
from
2c9768a to
f7395cc
Compare
Author
|
PR is ready for review |
UdjinM6
requested changes
Oct 13, 2019
codablock
force-pushed
the
pr_gitlabci
branch
6 times, most recently
from
026cfe5 to
74a108b
Compare
Author
|
Current test build is running here: https://gitlab.com/codablock/dash/pipelines/88568571 Changes done since initial PR:
|
codablock
force-pushed
the
pr_gitlabci
branch
from
58fd6d9 to
58381b6
Compare
Author
|
Building/Testing on Gitlab CI revealed issues with test nodes stopping behavior which required to backport a few PRs. I'll create a new PR for these backports later and will then remove the commits from this PR after the backports got merged. |
Author
|
First green build: https://gitlab.com/codablock/dash/pipelines/88676598 :) |
This honor new-lines and makes ; unnecessary
Creating 4 quorums causes a lot of blocks to be created and signed by ChainLocks, which then causes timeouts later.
The first dumpwallet is quite slow sometimes, which then makes the later called dumpwallet throw a wallet locked exception.
codablock
force-pushed
the
pr_gitlabci
branch
from
5533f85 to
98554ea
Compare
Author
|
Rebased, removed commits related to #3153 and force pushed. New build is running here: https://gitlab.com/codablock/dash/pipelines/89066282 |
Author
|
Test failures on Travis are unrelated and fixed by #3157 |
Author
|
First build for the official Gitlab dash repo and develop is running here: https://gitlab.com/dashpay/dash/pipelines/89163738 |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
* Add .gitlab-ci.yml * Use | instead of > for multiline commands This honor new-lines and makes ; unnecessary * Use ubuntu:bionic as base image * Move cache initialization before apt-get installs * Cache apt packages * Move installation of wget and unzip up as we need it for the cache * Prevent apt from deleting caches * Collect test logs into artifact * Make combine_logs.py always look for the template in the correct dir * Move final cache stuff into after_script * Reintroduce PYTHON_DEBUG=1, but only for .travis.yml * Install jinja2 in Travis builder image * Enable ChainLocks after quorums have been created Creating 4 quorums causes a lot of blocks to be created and signed by ChainLocks, which then causes timeouts later. * Increase timeout in wallet-dump.py test The first dumpwallet is quite slow sometimes, which then makes the later called dumpwallet throw a wallet locked exception.
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 23, 2025
…s badge from README 8f86e1b chore: remove GitLab CI configuration file, remove status from README (Kittywhiskers Van Gogh) Pull request description: ## Additional Information As we are decommissioning our GitLab CI runners (which made their debut in [dash#3149](#3149) in 2019) in favour of GitHub Actions (which as noted in [dash#6663](#6663) is now at feature-parity with GitLab CI), this pull request removes the `.gitlab-ci.yml` configuration and updates our badges in `README.md` to reflect this change. Gone but not forgotten. Sayonara, GitLab CI! 2019-2025. ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 8f86e1b thephez: utACK 8f86e1b UdjinM6: utACK 8f86e1b Tree-SHA512: 3dce3de4adfb7b769f8c360699711686c6360e7f48769a0b962d401189ce042f7c398f91d3dcc046d723667ba048732b3d74c5f3ee8fd12e17a19fbfe8124991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.gitlab-ci.ymlfile which mirror what we currently do on Travis. The advantage with Gitlab CI is that we don't really need to handle the "build in docker" stuff that we were doing in Travis, as Gitlab naturally executes all jobs in self-specified Docker images.The mirrored Gitlab repository is here: https://gitlab.com/dashpay/dash
The build won't be triggered for now as
.gitlab-ci.ymlis missing from the develop branch atm. But you can see example pipelines in my private repo: https://gitlab.com/codablock/dash/pipelines which are building my private dash repo.I used ablock/dash-gitlabci-builder as base image for jobs. This image simply has all the needed apt packages preinstalled to speed up the build. The Github repo for this image is here and automated builds are set up. I can later move this image to the dashpay organization if requested.
The .gitlab-ci.yml currently misses the automated Docker build for
dashpay/dashd-develop, as I didn't want to interfere with the main build. I'll add this later when/if we decide to move to Gitlab.