Skip to content

Commit fe99cda

Browse files
PastaPastaPastathephezUdjinM6
authored
code review comments
Co-authored-by: thephez <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
1 parent 201b44e commit fe99cda

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

doc/release-notes.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,31 +35,31 @@ is now packaged in a ZIP archive. The macOS distribution is once again notarized
3535
BIP324 / v2 P2P Protocol
3636
------------------------
3737

38-
Version 2 of the Dash P2P protocol / BIP324, which enables encryption of the p2p protocol
38+
Version 2 of the Dash P2P protocol / BIP324, which enables encryption of the p2p protocol,
3939
has been enabled by default in this version. This was initially introduced in Dash Core
40-
v22.0.0 as an experimental feature, and has been now enabled by default. This change is
41-
backwards compatible, and connections to peers which do not support the v2 protocol will
40+
v22.0.0 as an experimental feature and has now been enabled by default. This change is
41+
backward compatible, and connections to peers which do not support the v2 protocol will
4242
revert to using the v1 protocol.
4343

4444
Network Changes
4545
---------------
4646
System ports, or ports that are lower than 1024 are now considered to be "bad" ports.
4747
As a result, other peers will avoid connecting to nodes that are listening on these ports.
48-
This change is to prevent potential DDoS attacks on services that are running on these ports.
48+
This change is to prevent potential DDoS attacks against services running on these ports.
4949
A number of other ports commonly used for authenticated services are also considered "bad" ports.
5050
You can view [the list of bad ports here](doc/p2p-bad-ports.md).
5151

5252
Tests
5353
-----
5454

55-
- Command line arguments -dip8params, -bip147height are removed in favour of -testactivationheight. (dash#6325)
56-
- A number of hard forks now activate earlier on regtest.
55+
- Command line arguments `-dip8params`, `-bip147height` are removed in favour of `-testactivationheight`. (dash#6325)
56+
- Several hard forks now activate earlier on regtest.
5757

5858
## New RPCs
5959

6060
- **`getislocks`**
6161
- Retrieves the InstantSend lock data for the given transaction IDs (txids).
62-
Returns the lock information in both human-friendly JSON format and binary hex-encoded zmq-compatible format.
62+
Returns the lock information in both a human-friendly JSON format and a binary hex-encoded zmq-compatible format.
6363

6464
Updated RPCs
6565
------------
@@ -70,7 +70,7 @@ Updated RPCs
7070
are deprecated and will be removed in the next major version (use
7171
`-deprecated=fees` if needed in this version). The same fee fields can be accessed
7272
through the `fees` object in the result. WARNING: deprecated
73-
fields `ancestorfees` and `descendantfees` are denominated in sats, whereas all
73+
fields `ancestorfees` and `descendantfees` are denominated in duffs, whereas all
7474
fields in the `fees` object are denominated in DASH.
7575
- **`getbestchainlock` Changes**
7676
- A new hex field has been added to the getbestchainlock RPC, which returns the ChainLock information in zmq-compatible, hex-encoded binary format.
@@ -81,8 +81,8 @@ Updated RPCs
8181
GUI changes
8282
-----------
8383

84-
- UTXOs which are locked via the GUI are now stored persistently in the
85-
wallet database, so are not lost on node shutdown or crash.
84+
- UTXOs locked via the GUI are now stored persistently in the
85+
wallet database and are not lost on node shutdown or crash.
8686
- Improved GUI responsiveness for large wallets. (dash#6457)
8787

8888
# v22.1.0 Change log
@@ -97,6 +97,7 @@ Thanks to everyone who directly contributed to this release:
9797
- Konstantin Akimov
9898
- PastaPastaPasta
9999
- UdjinM6
100+
- Vijaydasmp
100101

101102
As well as everyone that submitted issues, reviewed pull requests and helped
102103
debug the release candidates.

0 commit comments

Comments
 (0)