wallet: Fail if maximum weight is too large

kwvg · kwvg · commit ab756ba31c92 · 2025-02-09T09:22:11.000Z
Courtesy of 3e69939 from bitcoin#20536
diff --git a/src/wallet/spend.cpp b/src/wallet/spend.cpp
@@ -958,7 +958,8 @@ bool CWallet::CreateTransactionInternal(
         tx = MakeTransactionRef(std::move(txNew));
 
         // Limit size
-        if (static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE) {
+        if ((sign && ::GetSerializeSize(*tx, PROTOCOL_VERSION) > MAX_STANDARD_TX_SIZE) ||
+            (!sign && static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE)) {
             error = _("Transaction too large");
             return false;
         }

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,8 @@ bool CWallet::CreateTransactionInternal(`
`958`	`958`	`tx = MakeTransactionRef(std::move(txNew));`
`959`	`959`
`960`	`960`	`// Limit size`
`961`		`- if (static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE) {`
	`961`	`+ if ((sign && ::GetSerializeSize(*tx, PROTOCOL_VERSION) > MAX_STANDARD_TX_SIZE) \|\|`
	`962`	`+ (!sign && static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE)) {`
`962`	`963`	`error = _("Transaction too large");`
`963`	`964`	`return false;`
`964`	`965`	`}`