merge bitcoin#25497: more accurate target for large transactions

kwvg · kwvg · commit 66fe2d4a82ce · 2025-02-09T09:22:12.000Z
diff --git a/src/wallet/spend.cpp b/src/wallet/spend.cpp
@@ -747,7 +747,8 @@ bool CWallet::CreateTransactionInternal(
 
                 // vouts to the payees
                 if (!coin_selection_params.m_subtract_fee_outputs) {
-                    coin_selection_params.tx_noinputs_size = 10; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count, 1 output count
+                    coin_selection_params.tx_noinputs_size = 9; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count
+                    coin_selection_params.tx_noinputs_size += GetSizeOfCompactSize(vecSend.size()); // bytes for output count
                 }
                 for (const auto& recipient : vecSend)
                 {

Original file line number	Diff line number	Diff line change
`@@ -747,7 +747,8 @@ bool CWallet::CreateTransactionInternal(`
`747`	`747`
`748`	`748`	`// vouts to the payees`
`749`	`749`	`if (!coin_selection_params.m_subtract_fee_outputs) {`
`750`		`- coin_selection_params.tx_noinputs_size = 10; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count, 1 output count`
	`750`	`+ coin_selection_params.tx_noinputs_size = 9; // Static vsize overhead + outputs vsize. 4 nVersion, 4 nLocktime, 1 input count`
	`751`	`+ coin_selection_params.tx_noinputs_size += GetSizeOfCompactSize(vecSend.size()); // bytes for output count`
`751`	`752`	`}`
`752`	`753`	`for (const auto& recipient : vecSend)`
`753`	`754`	`{`