test: validate that the 'submit' argument works as intended

Author: kwvg

doc/release-notes-6720.md

@@ -0,0 +1,4 @@
+Updated RPCs
+------------
+
+* A new optional field `submit` has been introduced to the `protx revoke`, `protx update_registrar`, `protx update_service` RPCs. It behaves identically to `submit` in `protx register` or `protx register_fund`.

test/functional/test_framework/test_framework.py

@@ -1242,6 +1242,11 @@ def register(self, node: TestNode, submit: bool, collateral_txid: Optional[str]
         ]
         address_funds = fundsAddr or self.fundsAddr
 
+        # Flip a coin and decide if we will submit the transaction directly or use sendrawtransaction
+        use_srt: bool = bool(random.getrandbits(1)) and submit
+        if use_srt:
+            submit = False
+
         # Construct final command and arguments
         if self.evo:
             command = "register_evo"
@@ -1250,7 +1255,11 @@ def register(self, node: TestNode, submit: bool, collateral_txid: Optional[str]
             command = "register_legacy" if self.legacy else "register"
             args = args + [address_funds, submit] # type: ignore
 
-        return node.protx(command, *args)
+        ret: str = node.protx(command, *args)
+        if use_srt:
+            ret = node.sendrawtransaction(ret)
+
+        return ret
 
     def register_fund(self, node: TestNode, submit: bool, collateral_address: Optional[str] = None, ipAndPort: Optional[str] = None,
                       ownerAddr: Optional[str] = None, pubKeyOperator: Optional[str] = None, votingAddr: Optional[str] = None,
@@ -1265,6 +1274,11 @@ def register_fund(self, node: TestNode, submit: bool, collateral_address: Option
             if platform_http_port is None:
                 raise AssertionError("EvoNode but platform_http_port is missing, must be specified!")
 
+        # Flip a coin and decide if we will submit the transaction directly or use sendrawtransaction
+        use_srt: bool = bool(random.getrandbits(1)) and submit
+        if use_srt:
+            submit = False
+
         # Common arguments shared between regular masternodes and EvoNodes
         args = [
             collateral_address or self.collateral_address,
@@ -1285,7 +1299,11 @@ def register_fund(self, node: TestNode, submit: bool, collateral_address: Option
             command = "register_fund_legacy" if self.legacy else "register_fund"
             args = args + [address_funds, submit] # type: ignore
 
-        return node.protx(command, *args)
+        ret: str = node.protx(command, *args)
+        if use_srt:
+            ret = node.sendrawtransaction(ret)
+
+        return ret
 
     def revoke(self, node: TestNode, submit: bool, reason: int, fundsAddr: Optional[str] = None) -> str:
         # Update commands should be run from the appropriate MasternodeInfo instance, we do not allow overriding some values for this reason
@@ -1294,6 +1312,11 @@ def revoke(self, node: TestNode, submit: bool, reason: int, fundsAddr: Optional[
         if self.keyOperator is None:
             raise AssertionError("keyOperator not set, did you call generate_addresses()")
 
+        # Flip a coin and decide if we will submit the transaction directly or use sendrawtransaction
+        use_srt: bool = bool(random.getrandbits(1)) and submit and (fundsAddr is not None)
+        if use_srt:
+            submit = False
+
         args = [
             self.proTxHash,
             self.keyOperator,
@@ -1306,14 +1329,23 @@ def revoke(self, node: TestNode, submit: bool, reason: int, fundsAddr: Optional[
         elif submit is not True:
             raise AssertionError("Cannot withhold transaction if relying on fundsAddr fallback behavior")
 
-        return node.protx('revoke', *args)
+        ret: str = node.protx('revoke', *args)
+        if use_srt:
+            ret = node.sendrawtransaction(ret)
+
+        return ret
 
     def update_registrar(self, node: TestNode, submit: bool, pubKeyOperator: Optional[str] = None, votingAddr: Optional[str] = None,
                          rewards_address: Optional[str] = None, fundsAddr: Optional[str] = None) -> str:
         # Update commands should be run from the appropriate MasternodeInfo instance, we do not allow overriding proTxHash for this reason
         if self.proTxHash is None:
             raise AssertionError("proTxHash not set, did you call set_params()")
 
+        # Flip a coin and decide if we will submit the transaction directly or use sendrawtransaction
+        use_srt: bool = bool(random.getrandbits(1)) and submit and (fundsAddr is not None)
+        if use_srt:
+            submit = False
+
         command = 'update_registrar_legacy' if self.legacy else 'update_registrar'
         args = [
             self.proTxHash,
@@ -1328,7 +1360,11 @@ def update_registrar(self, node: TestNode, submit: bool, pubKeyOperator: Optiona
         elif submit is not True:
             raise AssertionError("Cannot withhold transaction if relying on fundsAddr fallback behavior")
 
-        return node.protx(command, *args)
+        ret: str = node.protx(command, *args)
+        if use_srt:
+            ret = node.sendrawtransaction(ret)
+
+        return ret
 
     def update_service(self, node: TestNode, submit: bool, ipAndPort: Optional[str] = None, platform_node_id: Optional[str] = None, platform_p2p_port: Optional[int] = None,
                        platform_http_port: Optional[int] = None, address_operator: Optional[str] = None, fundsAddr: Optional[str] = None) -> str:
@@ -1347,6 +1383,11 @@ def update_service(self, node: TestNode, submit: bool, ipAndPort: Optional[str]
             if platform_http_port is None:
                 raise AssertionError("EvoNode but platform_http_port is missing, must be specified!")
 
+        # Flip a coin and decide if we will submit the transaction directly or use sendrawtransaction
+        use_srt: bool = bool(random.getrandbits(1)) and submit
+        if use_srt:
+            submit = False
+
         # Common arguments shared between regular masternodes and EvoNodes
         args = [
             self.proTxHash,
@@ -1364,7 +1405,11 @@ def update_service(self, node: TestNode, submit: bool, ipAndPort: Optional[str]
             command = "update_service"
             args = args + [address_operator, address_funds, submit] # type: ignore
 
-        return node.protx(command, *args)
+        ret: str = node.protx(command, *args)
+        if use_srt:
+            ret = node.sendrawtransaction(ret)
+
+        return ret
 
 class DashTestFramework(BitcoinTestFramework):
     def set_test_params(self):