From 1ae508dc106154c092b9415707463d3fc12d762d Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Thu, 12 Mar 2026 20:35:42 -0500 Subject: [PATCH 1/2] fix: include identity name in auth key missing error messages When an identity lacks an authentication key for signing document transitions, the error message now includes the identity name or base58 ID so users with multiple identities can identify which one has the problem. Closes dashpay/dash-evo-tool#743 --- src/backend_task/identity/register_dpns_name.rs | 8 ++++---- src/ui/identities/mod.rs | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/backend_task/identity/register_dpns_name.rs b/src/backend_task/identity/register_dpns_name.rs index baee1f9c1..fb7cf18c1 100644 --- a/src/backend_task/identity/register_dpns_name.rs +++ b/src/backend_task/identity/register_dpns_name.rs @@ -125,10 +125,10 @@ impl AppContext { let public_key = qualified_identity .document_signing_key(&preorder_document_type) - .ok_or( - "Identity doesn't have an authentication key for signing document transitions" - .to_string(), - )?; + .ok_or(format!( + "Identity {} doesn't have an authentication key for signing document transitions", + qualified_identity.display_string() + ))?; // Estimate fees for DPNS registration (2 document batch transitions) let fee_estimator = PlatformFeeEstimator::new(); diff --git a/src/ui/identities/mod.rs b/src/ui/identities/mod.rs index d582aa176..753ced629 100644 --- a/src/ui/identities/mod.rs +++ b/src/ui/identities/mod.rs @@ -78,8 +78,10 @@ pub fn get_selected_wallet( qualified_identity .document_signing_key(&preorder_document_type) .ok_or_else(|| { - "Identity doesn't have an authentication key for signing document transitions" - .to_string() + format!( + "Identity {} doesn't have an authentication key for signing document transitions", + qualified_identity.display_string() + ) })? } else { // Fallback: directly use the provided selected key. From 4b01b04d0be0703f5463a92e02c5b8b3f63c8c76 Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Thu, 12 Mar 2026 20:41:31 -0500 Subject: [PATCH 2/2] refactor: use ok_or_else for lazy error formatting in DPNS name registration --- src/backend_task/identity/register_dpns_name.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/backend_task/identity/register_dpns_name.rs b/src/backend_task/identity/register_dpns_name.rs index fb7cf18c1..6b3df4036 100644 --- a/src/backend_task/identity/register_dpns_name.rs +++ b/src/backend_task/identity/register_dpns_name.rs @@ -125,10 +125,12 @@ impl AppContext { let public_key = qualified_identity .document_signing_key(&preorder_document_type) - .ok_or(format!( - "Identity {} doesn't have an authentication key for signing document transitions", - qualified_identity.display_string() - ))?; + .ok_or_else(|| { + format!( + "Identity {} doesn't have an authentication key for signing document transitions", + qualified_identity.display_string() + ) + })?; // Estimate fees for DPNS registration (2 document batch transitions) let fee_estimator = PlatformFeeEstimator::new();