Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code #21

Open
dascritch opened this issue Nov 12, 2017 · 0 comments
Open

Refactoring code #21

dascritch opened this issue Nov 12, 2017 · 0 comments

Comments

@dascritch
Copy link
Owner

Via e-mail :

A reviewer sent a message regarding the review of version 1.0 of add-on Anchors reveal.

erosman wrote:

Please note the following for the next update:

  1. For inserting text, textContent (or JQuery text) or createTextNode() should be used instead of innerHTML.
    eg:
    legends[0].innerHTML = browser.i18n.getMessage('themeParameterDescription');

  2. Add-on contains duplicate/hidden/unused/unnecessary files or folders. These complicate the review process and may contain sensitive information about the system you created the XPI on. Such files may also create cause for rejection. Please correct your packaging process so that these files aren't included.
    e.g.:
    lib.js

If you want to respond please reply to this email or visit https://addons.mozilla.org/en-US/developers/addon/anchors-reveal/versions

You are receiving this email because you are an author of this add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant