Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update paginator style #2069

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: update paginator style #2069

merged 2 commits into from
Jan 30, 2025

Conversation

derschnee68
Copy link
Collaborator

new style, overviewed with Daniela :
Screenshot 2025-01-29 at 12 35 36

@derschnee68 derschnee68 changed the title fix: improve style fix: update paginator style Jan 29, 2025
Comment on lines +43 to +46
display: flex;
flex-direction: row-reverse;
padding-right: 16px;
font-size: 0.7em;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe try to make it as a rule, to sort alphabetically styles, which I believe will make them easier to read, especially in longer blocks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should discuss this in FE meeting, the best IMO would be to have a linter rule so that it's done automatically. Also this would change a lot with css global classes

@domsteinbach domsteinbach self-requested a review January 29, 2025 12:43
@derschnee68 derschnee68 merged commit 057f16c into main Jan 30, 2025
10 checks passed
@derschnee68 derschnee68 deleted the julien/ui-paginator branch January 30, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants