Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove user from a project (DEV-2328) #2067

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

irmastnt
Copy link
Contributor

resolves DEV-2328

Copy link

linear bot commented Jan 28, 2025

Comment on lines +23 to +28
<span *ngIf="projectUuid" data-cy="member-count"
>{{ list.length | i18nPlural : itemPluralMapping['member'] }}</span
>
<span *ngIf="!projectUuid" data-cy="user-count"
>{{ list.length | i18nPlural : itemPluralMapping['user'] }}</span
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about formatting. Is this guys what you have agreed on or just a Prettier bug? I see it looks different and weird for me than in other files touched in this PR.

<tag attributes
  >value</tag>
>

vs what is in below changes and what looks more readable:

<tag
  attributes>
  <tag2>value</tag2>
</tag>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpro7 It just exceeds 120 characters in a line which is the rule of prettier

@irmastnt irmastnt merged commit 07a8dc4 into main Feb 3, 2025
14 checks passed
@irmastnt irmastnt deleted the wip/DEV-2328-eu-remove-a-user-from-a-project-e2e branch February 3, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants