Locked collateral for each order by boundless-forest · Pull Request #910 · darwinia-network/darwinia-common

boundless-forest · 2021-11-05T06:45:59Z

Too many things are included in this pr, I made a list to help review.

Update List:

Rename AssignedRelayersStorage to AssignedRelayers , migration needed.
Rename first_and_last_fee() to lowest_and_highest_fee.
Delete one config type MiniumLockCollateral and introduce another type CollateralEachOrder. The original MiniumLockCollateral was used to limit the minimum locked collateral when relayers enroll. At the same time, MiniumLockCollateral was the maximum slash amount for each assigned relayer when relaying delay occurred. A drawback this implementation has is how the market reward message relayer and confirm relayers for a delay message whose assigned relayers' original collateral had been slashed out. I made a change about this issue in this pull request. Introduce order_capacity for the relayer to indicate the ability to accept the order task. The capacity is calculated as locked_collateral / CollateralEachOrder. The relayer who has more collateral locked has more order_capacity, can eat more relaying orders. One thing that should be noted is the selection of assigned relayers also have a relationship with relayer order capacity.
Slash logic update, the maximum slash value change to CollateralEachOrder. Once a message is delayed, slash CollateralEachOrder collateral.

TODO:

Data Migration for AssignedRelayers and Relayer.
Benchmark test update
Update readme docs

github-actions · 2021-11-05T07:56:56Z

Commit 3a54d34

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet Substrate2SubstrateIssuing:
+ 	Item: Storage { name: "RemoteBackingAccount", type: Plain("AccountId<T>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Commit e57efd2

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet Substrate2SubstrateIssuing:
+ 	Item: Storage { name: "RemoteBackingAccount", type: Plain("AccountId<T>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Commit 711bb66

Pangolin

Check Runtime Version

Runtime Version {
	spec_name: Pangolin
	impl_name: Pangolin
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 4
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pallet Substrate2SubstrateIssuing:
+ 	Item: Storage { name: "RemoteBackingAccount", type: Plain("AccountId<T>") }

+ Pallet: "TransactionPause"

Pangoro

Check Runtime Version

Runtime Version {
	spec_name: Pangoro
	impl_name: Pangoro
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 3
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

+ Pallet: "TransactionPause"

Commit 0199bcf

Pangolin

Check Runtime Version

Runtime Version {
	spec_name: Pangolin
	impl_name: Pangolin
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 4
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pallet Substrate2SubstrateIssuing:
+ 	Item: Storage { name: "RemoteBackingAccount", type: Plain("AccountId<T>") }

+ Pallet: "TransactionPause"

Pangoro

Check Runtime Version

Runtime Version {
	spec_name: Pangoro
	impl_name: Pangoro
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 3
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

+ Pallet: "TransactionPause"

Commit e631671

Pangolin

Check Runtime Version

Runtime Version {
	spec_name: Pangolin
	impl_name: Pangolin
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 4
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pallet Substrate2SubstrateIssuing:
+ 	Item: Storage { name: "RemoteBackingAccount", type: Plain("AccountId<T>") }

+ Pallet: "TransactionPause"

Pangoro

Check Runtime Version

Runtime Version {
	spec_name: Pangoro
	impl_name: Pangoro
	authoring_version: 1
-	spec_version: 2680
+	spec_version: 2690
	impl_version: 1
	transaction_version: 3
}

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

+ Pallet: "TransactionPause"

Commit 39a5f25

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit fb388ea

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 061f59f

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 902fe89

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit e96516b

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 7edd4e5

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit b5fc958

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit be9a7bb

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 76ed916

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 6d13787

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }

Commit 0cb142e

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Commit 7aa6d50

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Commit dfdbb80

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Commit 8bed973

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Commit f0da259

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Commit 9ff3e3d

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }
+ 	Item: Storage { name: "RewardModeStorage", type: Plain("RewardMode") }

Commit 1ee88ec

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Commit 58366e2

Pangolin

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

Pangoro

Check Runtime Version

Check Storage Prefix

Pallet ElectionProviderMultiPhase:
+ 	Item: Storage { name: "SignedSubmissionIndices", type: Plain("SubmissionIndicesOf<T>") }
+ 	Item: Storage { name: "SignedSubmissionNextIndex", type: Plain("u32") }
+ 	Item: Storage { name: "SignedSubmissionsMap", type: Map { hasher: Twox64Concat, key: "u32", value: "SignedSubmissionOf<T>", unused: false } }

Pallet FeeMarket:
+ 	Item: Storage { name: "AssignedRelayers", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
- 	Item: Storage { name: "AssignedRelayersStorage", type: Plain("Vec<Relayer<T::AccountId, RingBalance<T>>>") }
+ 	Item: Storage { name: "CollateralSlashProtect", type: Plain("RingBalance<T>") }
+ 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, RingBalance<T>>", unused: false } }
- 	Item: Storage { name: "Orders", type: Map { hasher: Blake2_128Concat, key: "(LaneId, MessageNonce)", value: "Order<T::AccountId, T::BlockNumber, Fee<T>>", unused: false } }

aurexav · 2021-11-09T10:32:07Z

Should we still keep Fee<T>?

BTW, Internal Review is not a good title.

hackfisher

LGTM, except one more change request related to remove_enrolled_relayer in slashing.

boundless-forest · 2021-11-12T04:02:29Z

Latest Pangoro try-runtime:

darwinia-common [update-fee-market]× » ./target/release/drml try-runtime --block-at 0x02f8023395efc0a6ef163dfc2875ecd41018aeca14aae3cd9f958d31cee8c0f0 --chain pangoro-dev -u wss://pangoro-rpc.darwinia.network on-runtime-upgrade live
2021-11-12 11:55:45 `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
2021-11-12 11:55:45 [#0] 🗳  Entering emergency mode: NoFallbackConfigured    
2021-11-12 11:55:45 [0] 💸 election provider failed due to NoFallbackConfigured    
2021-11-12 11:55:45 [#0] 🗳  Entering emergency mode: NoFallbackConfigured    
2021-11-12 11:55:45 [0] 💸 election provider failed due to NoFallbackConfigured    
2021-11-12 11:55:45 initializing remote client to "wss://pangoro-rpc.darwinia.network"    
2021-11-12 11:55:47 scraping key-pairs from remote @ 0x02f8023395efc0a6ef163dfc2875ecd41018aeca14aae3cd9f958d31cee8c0f0    
2021-11-12 11:55:47 downloading data for all modules.    
2021-11-12 11:56:12 Querying a total of 20156 keys    
2021-11-12 11:56:40 extending externalities with 1 manually injected key-values    
2021-11-12 11:56:40 injecting a total of 20158 keys    
2021-11-12 11:56:40 ===> Start migrate all storage items in AssignedRelayersStorage    
2021-11-12 11:56:40 the migrate content [Relayer { id: , collateral: 0, fee: 30000000000 }, Relayer { id: , collateral: 0, fee: 50000000000 }, Relayer { id: , collateral: 0, fee: 500000000000 }]    
2021-11-12 11:56:40 ===> End migrate all storage items in AssignedRelayersStorage    
2021-11-12 11:56:40 ===> Start migrate all storage items in Orders    
2021-11-12 11:56:40 The new order: order Order { lane: [114, 111, 108, 105], message: 62, sent_time: 1022299, confirm_time: None, locked_collateral: 100000000000, relayers: [PriorRelayer { id: , fee: 30000000000, valid_range: 1022299..1022349 }, PriorRelayer { id: , fee: 50000000000, valid_range: 1022349..1022399 }, PriorRelayer { id: , fee: 500000000000, valid_range: 1022399..1022449 }] }    
2021-11-12 11:56:40 ===> End migrate all storage items in Orders    
2021-11-12 11:56:40 ===> All Migrates finished    
2021-11-12 11:56:40 ⚠️ System declares internal migrations (which *might* execute), setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for TransactionPause, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for FeeMarket, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Substrate2SubstrateBacking, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for BridgePangolinGrandpa, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for BridgeDispatch, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for BridgePangolinMessages, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Scheduler, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Sudo, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for AuthorityDiscovery, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for ImOnline, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Grandpa, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Session, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Historical, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ⚠️ Offences declares internal migrations (which *might* execute), setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 have 0 deferred offences, applying.    
2021-11-12 11:56:40 ✅ no migration for Staking, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for ElectionProviderMultiPhase, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Authorship, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for TransactionPayment, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Kton, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Balances, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Timestamp, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for Babe, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 ✅ no migration for RandomnessCollectiveFlip, setting storage version to <wasm:stripped>    
2021-11-12 11:56:40 TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = 512646400000000, total weight = 512000000000000 (1.0012625)

hackfisher · 2021-11-12T04:15:54Z

Remove the Fee type in types.json

darwinia-common/node/runtime/pangolin/types.json

Line 261 in 7aa6d50

"Fee": "Balance",

and pangoro.

boundless-forest · 2021-11-12T07:52:38Z

@hackfisher @xiaoch05 Take a review again.

hackfisher · 2021-11-15T02:30:09Z

+		<AssignedRelayers<T>>::mutate(|assigned_relayers| {
+			if let Some(relayers) = assigned_relayers {
+				relayers.retain(|x| x.id != *who);
+			}
+		});


In which cases we will remove an relayer who is in assignment? Should we change this to use ensure!?

We need to update the assigned_relayers list when the enrolled relayer wants to exit the fee market by calling cancel_enrollment().

But assigned_relayers means there exists order for the relayer right, we do not allow cancel enrollment for the relayer if it has ongoing order?

But assigned_relayers means there exists order for the relayer right?

we use occupied(who: &T::AccountId).

we do not allow cancel enrollment for the relayer if it has ongoing order?

Yes, we will check whether the relayer have ongoing orders use ensure!(Self::occupied(&who).is_none(), <Error<T>>::OccupiedRelayer); before remove_enrolled_relayer.

aurexav · 2021-11-15T10:25:32Z

@sxlwar Types updated.

boundless-forest added 3 commits November 5, 2021 14:44

Update some renames

2c9c3a0

Rename

3a54d34

Code clean

88396b2

boundless-forest added 12 commits November 5, 2021 16:07

Revert reads and writes weight changes

e57efd2

Update review issues

37d92b7

Update review issues 2

1f790a5

Fix unit tests

d3469e7

Add order_capacity support

86c0752

Add inc,dec relayer_order_capacity

4675bee

Update slash logic to new design

c94e86f

Use / to get new order capacity

7669a5d

Do not break api, use original interface

99155a0

The code part finished, More unit tests needed.

b032415

Remove slasher

760fc37

Test 1

aefc80c

boundless-forest changed the title ~~Internal Review(Fee market)~~ Internal Review (Fee market) Nov 9, 2021

Test 2

06729d4

boundless-forest added 2 commits November 9, 2021 20:43

Test 3

1d25692

Good news, it's close to ready

711bb66

boundless-forest changed the title ~~Internal Review (Fee market)~~ Make fee market better Nov 9, 2021

boundless-forest added 5 commits November 9, 2021 21:39

Code clean

0199bcf

Add more comment

e631671

Add accept_order and finish_order

39a5f25

Update the whole slash logic

1ee8da0

Clean the tests

fb388ea

boundless-forest marked this pull request as ready for review November 10, 2021 04:03

boundless-forest requested review from aurexav and hackfisher as code owners November 10, 2021 04:03

hackfisher reviewed Nov 11, 2021

View reviewed changes

Comment thread frame/fee-market/src/lib.rs Outdated

hackfisher reviewed Nov 11, 2021

View reviewed changes

No need to remove slashed relayer

6d13787

xiaoch05 suggested changes Nov 11, 2021

View reviewed changes

Comment thread frame/fee-market/src/lib.rs

Comment thread frame/fee-market/src/s2s/payment.rs

Comment thread frame/fee-market/src/s2s/payment.rs Outdated

Comment thread frame/fee-market/src/lib.rs Outdated

Comment thread frame/fee-market/src/lib.rs Outdated

hackfisher reviewed Nov 11, 2021

View reviewed changes

Comment thread frame/fee-market/src/s2s/payment.rs

Comment thread frame/fee-market/src/lib.rs

Comment thread frame/fee-market/src/s2s/payment.rs Outdated

boundless-forest added 4 commits November 12, 2021 09:33

Revert to the original event

4f59e38

Remove Fee<T>

348814e

Merge branch 'master' into update-fee-market

0cb142e

Add orders data migration

7aa6d50

boundless-forest commented Nov 12, 2021

View reviewed changes

Comment thread node/runtime/pangolin/src/lib.rs

boundless-forest added 5 commits November 12, 2021 13:31

Update type.json

7ac1eaa

Add RewardMode to the fee market

f5d65f7

Support S(t)

dfdbb80

Update docs

8bed973

Use UpdateRewardMode instead of OperatingMode

f0da259

hackfisher reviewed Nov 12, 2021

View reviewed changes

Comment thread frame/fee-market/src/lib.rs Outdated

hackfisher reviewed Nov 12, 2021

View reviewed changes

Comment thread frame/fee-market/src/s2s/payment.rs Outdated

boundless-forest added 3 commits November 12, 2021 17:20

Bring Slasher back

02b9174

Return zero, if transfer failed

9ff3e3d

Add CollateralSlashProtect and test

1ee88ec

xiaoch05 reviewed Nov 15, 2021

View reviewed changes

Comment thread frame/fee-market/src/lib.rs

hackfisher reviewed Nov 15, 2021

View reviewed changes

Add more docs about the event params

58366e2

hackfisher approved these changes Nov 15, 2021

View reviewed changes

hackfisher merged commit c8832e5 into master Nov 15, 2021

hackfisher deleted the update-fee-market branch November 15, 2021 04:56

Conversation

boundless-forest commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aurexav commented Nov 9, 2021

Uh oh!

Uh oh!

hackfisher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boundless-forest commented Nov 12, 2021

Uh oh!

Uh oh!

hackfisher commented Nov 12, 2021

Uh oh!

boundless-forest commented Nov 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hackfisher Nov 15, 2021

Choose a reason for hiding this comment

Uh oh!

boundless-forest Nov 15, 2021

Choose a reason for hiding this comment

Uh oh!

hackfisher Nov 15, 2021

Choose a reason for hiding this comment

Uh oh!

boundless-forest Nov 15, 2021

Choose a reason for hiding this comment

Uh oh!

aurexav commented Nov 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

boundless-forest commented Nov 5, 2021 •

edited

Loading

github-actions Bot commented Nov 5, 2021 •

edited

Loading

hackfisher left a comment •

edited

Loading