Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std::allocator compatible memory allocator wrapper #1637

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 23, 2021

  • Add StlAllocator, a std::allocator compatible memory allocator wrapper

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1637 (25f8d84) into main (2507c72) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files         479      485    +6     
  Lines       40195    40272   +77     
=======================================
+ Hits        23699    23746   +47     
- Misses      16496    16526   +30     
Impacted Files Coverage Δ
dart/common/MemoryAllocator.cpp 27.27% <27.27%> (ø)
dart/common/CAllocator.cpp 71.11% <71.11%> (ø)
dart/common/detail/StlAllocator-impl.hpp 94.11% <94.11%> (ø)
dart/common/CAllocator.hpp 100.00% <100.00%> (ø)
dart/common/MemoryAllocator.hpp 100.00% <100.00%> (ø)
dart/common/StlAllocator.hpp 100.00% <100.00%> (ø)
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️
dart/dynamics/Skeleton.cpp 67.74% <0.00%> (-0.17%) ⬇️

@jslee02 jslee02 marked this pull request as ready for review December 24, 2021 00:03
@jslee02 jslee02 merged commit 096bc8c into main Dec 24, 2021
@jslee02 jslee02 deleted the stl_allocator branch December 24, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant