Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spdlog support as underlying logging framework #1633

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Add spdlog support as underlying logging framework #1633

merged 1 commit into from
Dec 23, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 23, 2021

  • Add new logging macros DART_TRACE, DART_DEBUG, DART_INFO, DART_WARN, DART_ERROR, DART_FATAL to replace dtmsg, dtdbg, dtwarn, dterr eventually
  • Add spdlog as an optional dependency

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve the build warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 23, 2021
@jslee02 jslee02 changed the title Add log macros Add log macros: DART_TRACE, DART_DEBUG, DART_INFO, DART_WARN, DART_ERROR, DART_FATAL Dec 23, 2021
@jslee02 jslee02 changed the title Add log macros: DART_TRACE, DART_DEBUG, DART_INFO, DART_WARN, DART_ERROR, DART_FATAL Add log macros Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1633 (6a676f4) into main (627f71e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 6a676f4 differs from pull request most recent head 18dcb52. Consider uploading reports for the commit 18dcb52 to get more accurate results

@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   58.93%   58.95%   +0.02%     
==========================================
  Files         477      479       +2     
  Lines       40166    40195      +29     
==========================================
+ Hits        23670    23696      +26     
- Misses      16496    16499       +3     
Impacted Files Coverage Δ
dart/common/detail/Logging-impl.hpp 100.00% <100.00%> (ø)
python/dartpy/common/Logging.cpp 100.00% <100.00%> (ø)
python/dartpy/common/module.cpp 100.00% <100.00%> (ø)
dart/dynamics/Skeleton.cpp 67.74% <0.00%> (-0.17%) ⬇️

@jslee02 jslee02 force-pushed the logging branch 2 times, most recently from a96ec8f to 7a17904 Compare December 23, 2021 17:07
@jslee02 jslee02 changed the title Add log macros Add spdlog support for logging framework Dec 23, 2021
@jslee02 jslee02 changed the title Add spdlog support for logging framework Add spdlog support as underlying logging framework Dec 23, 2021
@jslee02 jslee02 marked this pull request as ready for review December 23, 2021 19:53
@jslee02 jslee02 merged commit 2507c72 into main Dec 23, 2021
@jslee02 jslee02 deleted the logging branch December 23, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant