Skip to content

Commit bc78a37

Browse files
committed
Address reviewer feedback.
Signed-off-by: Addisu Z. Taddese <[email protected]>
1 parent b026553 commit bc78a37

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

dart/collision/CollisionGroup.hpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -218,18 +218,18 @@ class CollisionGroup
218218
/// template.
219219
void unsubscribeFrom();
220220

221-
// Check if this is subscribed to bodyNode and the other sources
221+
/// Check if this is subscribed to bodyNode and the other sources
222222
template <typename... Others>
223223
bool isSubscribedTo(
224224
const dynamics::BodyNode* bodyNode, const Others*... others);
225225

226-
// Check if this is subscribed to skeleton and the other sources
226+
/// Check if this is subscribed to skeleton and the other sources
227227
template <typename... Others>
228228
bool isSubscribedTo(
229229
const dynamics::Skeleton* skeleton, const Others*... others);
230230

231-
// Return true. This function is for terminating the recursive variadic
232-
// template
231+
/// Return true. This function is for terminating the recursive variadic
232+
/// template
233233
bool isSubscribedTo();
234234

235235
/// Return true if this CollisionGroup contains shapeFrame

unittests/unit/test_CollisionGroups.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription)
312312
boxShape);
313313

314314
// Needed to update subscribtions
315-
world->step(1);
315+
world->step();
316316

317317
EXPECT_TRUE(group->hasShapeFrame(sn));
318318
const auto* skel_A_ptr = skel_A.get();
@@ -322,7 +322,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription)
322322
world->removeSkeleton(skel_A);
323323
world->removeSkeleton(skel_B);
324324

325-
world->step(1);
325+
world->step();
326326

327327
EXPECT_FALSE(group->hasShapeFrame(sn));
328328
EXPECT_FALSE(group->isSubscribedTo(skel_A_ptr));

0 commit comments

Comments
 (0)