From 558f3a574753eebab0584141ba55f712476587f7 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Mon, 20 Jul 2026 23:48:12 +0000 Subject: [PATCH 1/3] Ignore dart2js output for successful compiles Followup to #2699 The compiler output had some utility when dart2js could be slow for some test runs, but it's likely ignored nearly always today. Drop the output from successful compiles and output only when the exit code indicates an error. Update test expectations accordingly. --- pkgs/test/CHANGELOG.md | 5 +++-- pkgs/test/test/runner/browser/loader_test.dart | 3 +-- pkgs/test/test/runner/browser/runner_test.dart | 2 +- pkgs/test/test/runner/node/runner_test.dart | 2 +- .../lib/src/runner/dart2js_compiler_pool.dart | 14 +++++--------- .../lib/src/runner/wasm_compiler_pool.dart | 9 +++++---- 6 files changed, 16 insertions(+), 19 deletions(-) diff --git a/pkgs/test/CHANGELOG.md b/pkgs/test/CHANGELOG.md index c43e85542..1cbee81cc 100644 --- a/pkgs/test/CHANGELOG.md +++ b/pkgs/test/CHANGELOG.md @@ -4,8 +4,9 @@ when tests are run directly on platforms which support `dart:io`. The environment variable takes precedence over configuration in `dart_test.yaml` but is overridden by the `--reporter` flag when passed to the test runner. -* Include passing test and suite loading messages within the `Passing tests` - group in `GithubReporter`. +* Suppress dart2js compiler output for successful compiles. +* Include output from passing tests messages within the `Passing tests` group + in `GithubReporter`. ## 1.31.2 diff --git a/pkgs/test/test/runner/browser/loader_test.dart b/pkgs/test/test/runner/browser/loader_test.dart index d14989520..ba3f56c34 100644 --- a/pkgs/test/test/runner/browser/loader_test.dart +++ b/pkgs/test/test/runner/browser/loader_test.dart @@ -174,9 +174,8 @@ void main() { var loadSuite = suites.first; var liveTest = (loadSuite.group.entries.single as Test).load(loadSuite); - // Skip the "Compiled" message from dart2js. expect( - liveTest.onMessage.skip(1).first.then((message) => message.text), + liveTest.onMessage.first.then((message) => message.text), completion(equals('print within test')), ); await liveTest.run(); diff --git a/pkgs/test/test/runner/browser/runner_test.dart b/pkgs/test/test/runner/browser/runner_test.dart index 637970df9..58a898fdb 100644 --- a/pkgs/test/test/runner/browser/runner_test.dart +++ b/pkgs/test/test/runner/browser/runner_test.dart @@ -41,7 +41,7 @@ void main() { containsInOrder([ 'Error: Compilation failed.', '-1: loading test.dart [E]', - 'Failed to load "test.dart": dart2js failed.', + 'Failed to load "test.dart": Bad state: dart2js failed.', ]), ); await test.shouldExit(1); diff --git a/pkgs/test/test/runner/node/runner_test.dart b/pkgs/test/test/runner/node/runner_test.dart index d9f7c2390..05f5b4d0a 100644 --- a/pkgs/test/test/runner/node/runner_test.dart +++ b/pkgs/test/test/runner/node/runner_test.dart @@ -86,7 +86,7 @@ void main() { containsInOrder([ 'Error: Compilation failed.', '-1: loading test.dart [E]', - 'Failed to load "test.dart": dart2js failed.', + 'Failed to load "test.dart": Bad state: dart2js failed.', ]), ); await test.shouldExit(1); diff --git a/pkgs/test_core/lib/src/runner/dart2js_compiler_pool.dart b/pkgs/test_core/lib/src/runner/dart2js_compiler_pool.dart index 5bea2ee39..0f92626cb 100644 --- a/pkgs/test_core/lib/src/runner/dart2js_compiler_pool.dart +++ b/pkgs/test_core/lib/src/runner/dart2js_compiler_pool.dart @@ -13,11 +13,6 @@ import '../util/package_config.dart'; import 'compiler_pool.dart'; import 'suite.dart'; -/// A regular expression matching the first status line printed by dart2js. -final _dart2jsStatus = RegExp( - r'^Dart file \(.*\) compiled to JavaScript: .*\n?', -); - /// A pool of `dart2js` instances. /// /// This limits the number of compiler instances running concurrently. @@ -88,10 +83,11 @@ class Dart2JsCompilerPool extends CompilerPool { _processes.remove(process); if (closed) return; - var output = buffer.toString().replaceFirst(_dart2jsStatus, ''); - if (output.isNotEmpty) print(output); - - if (exitCode != 0) throw 'dart2js failed.'; + if (exitCode != 0) { + var output = buffer.toString(); + if (output.isNotEmpty) print(output); + throw StateError('dart2js failed.'); + } _fixSourceMap('$path.map'); }); diff --git a/pkgs/test_core/lib/src/runner/wasm_compiler_pool.dart b/pkgs/test_core/lib/src/runner/wasm_compiler_pool.dart index 9993c1d57..7fd5cdd03 100644 --- a/pkgs/test_core/lib/src/runner/wasm_compiler_pool.dart +++ b/pkgs/test_core/lib/src/runner/wasm_compiler_pool.dart @@ -77,10 +77,11 @@ class WasmCompilerPool extends CompilerPool { _processes.remove(process); if (closed) return; - var output = buffer.toString(); - if (output.isNotEmpty) print(output); - - if (exitCode != 0) throw StateError('dart2wasm failed.'); + if (exitCode != 0) { + var output = buffer.toString(); + if (output.isNotEmpty) print(output); + throw StateError('dart2wasm failed.'); + } }); } From 34d63066167c7245b81d80f792e514cb437cd7db Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Tue, 21 Jul 2026 00:05:43 +0000 Subject: [PATCH 2/3] test_core changelog too --- pkgs/test_core/CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/test_core/CHANGELOG.md b/pkgs/test_core/CHANGELOG.md index 9e27603ea..d5a173403 100644 --- a/pkgs/test_core/CHANGELOG.md +++ b/pkgs/test_core/CHANGELOG.md @@ -1,8 +1,9 @@ ## 0.6.20-wip * Add support for `DART_TEST_REPORTER` environment variable. -* Include passing test and suite loading messages within the `Passing tests` - group in `GithubReporter`. +* Suppress dart2js compiler output for successful compiles. +* Include passing test messages within the `Passing tests` group in + `GithubReporter`. ## 0.6.19 From c9889468c45ce3afc7b30e35a556eacac7e21f21 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Tue, 21 Jul 2026 00:07:57 +0000 Subject: [PATCH 3/3] Fix json reporter test --- pkgs/test/test/runner/json_reporter_test.dart | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/pkgs/test/test/runner/json_reporter_test.dart b/pkgs/test/test/runner/json_reporter_test.dart index 41d978b69..a984248a5 100644 --- a/pkgs/test/test/runner/json_reporter_test.dart +++ b/pkgs/test/test/runner/json_reporter_test.dart @@ -630,14 +630,6 @@ void main() { [ suiteJson(0, platform: 'chrome'), testStartJson(1, 'loading test.dart', groupIDs: []), - printJson( - 1, - isA().having( - (s) => s.split('\n'), - 'lines', - contains(startsWith('Compiled')), - ), - ), testDoneJson(1, hidden: true), ], [ @@ -847,14 +839,6 @@ void customTest(String name, dynamic Function() testFn) => test(name, testFn); [ suiteJson(0, platform: 'chrome'), testStartJson(1, 'loading test.dart', groupIDs: []), - printJson( - 1, - isA().having( - (s) => s.split('\n'), - 'lines', - contains(startsWith('Compiled')), - ), - ), testDoneJson(1, hidden: true), ], [