Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yellow is not a primary colour #6169

Closed
wants to merge 1 commit into from
Closed

yellow is not a primary colour #6169

wants to merge 1 commit into from

Conversation

dmcg
Copy link

@dmcg dmcg commented Oct 24, 2024

Changed yellow to green, as yellow is not a primary color, so the example is wrong

Copy link

google-cla bot commented Oct 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dmcg
Copy link
Author

dmcg commented Oct 24, 2024

I signed the CLA but nothing is happening

@MaryaBelanger
Copy link
Contributor

I had to look it up, but...

image

Closing this, but for next time: looks like your CLA was accepted but the check that was failing was "Check if code excerpts are up to date". If you look at line 192 above the line you changed, there's a path to a corresponding dart file that needs to change along with the example in the markdown (this section in the repo readme has more info)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants