Skip to content

Add support for http2 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Sep 8, 2015 · 5 comments
Closed

Add support for http2 #50

kevmoo opened this issue Sep 8, 2015 · 5 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Sep 8, 2015

Now that we have https://github.com/dart-lang/http2

@kevmoo kevmoo added the type-enhancement A request for a change that isn't a bug label Sep 8, 2015
@nex3
Copy link
Member

nex3 commented Sep 8, 2015

Given that http2 is its own package (and that it's marked experimental), it seems like it would be better for it to provide its own shelf adapter rather than baking one into shelf itself. Alternately, one could be made in its own shelf_http2 package.

@mkustermann
Copy link
Member

I've made a proof of concept of a shelf adaptor which is available here: mkustermann@80329c2 This just exposes a new serveSecure method. An example can be found example/multiprotocol_server.dart. Feel free to try it out and provide feedback.

@mhoad
Copy link

mhoad commented May 5, 2022

Just wondering if this is something that there is any interest in revisiting at all?

My particular use case is wanting to run a HTTP/2 service on Cloud Run which has a requirement to ensure that HTTP/2 is done without SSL using h2c (Relevant details here and here)

I’ve already confirmed that this works just using the standard http2 package but obviously don’t want to rebuild a worse version of Shelf on top of it.

I saw that the proof of concept posted in this thread made it seem like perhaps this wasn’t a major bit of work but didn’t want to sound too confident in that assumption at the same time.

The other major reason I’m interested in this is that it would really simplify some of the logic I have to write when it comes to handling headers since they are much more standardised in HTTP/2 along with the performance benefits it provides.

So it’s in that spirit I wanted to ask if this was a topic anyone is open to revisiting?

@donywan
Copy link

donywan commented Oct 6, 2024

Any more?

@kevmoo
Copy link
Member Author

kevmoo commented Oct 8, 2024

I think someone should just create their own package shelf_http2 or similar. It's unlikely we'll put an http2 server impl here!

@kevmoo kevmoo closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants