From d0452dca57c1a38da852cf85527b316cbc78f328 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Tue, 19 Nov 2024 12:24:49 +0000 Subject: [PATCH 1/2] Install a Flutter SDK in the publish workflow --- .github/workflows/publish.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 66a892a..fca49b1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -31,6 +31,12 @@ jobs: - uses: actions/checkout@v4 # Setup Dart SDK with JWT token - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 + # Download flutter SDK - needed for publishing Flutter packages. Can also + # publish pure Dart packages. + # + # This will add the flutter/bin/dart executable to path, that sets up + # FLUTTER_ROOT. + - uses: flutter-actions/setup-flutter@d030cb603380106494f72d65a7e52462f380781f # Minimal package setup and dry run checks. - name: Install dependencies run: dart pub get From fa7cc962dc1f35f6e38a0cc568380b73e359e605 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Thu, 21 Nov 2024 11:09:45 +0000 Subject: [PATCH 2/2] Clarify comments --- .github/workflows/publish.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index fca49b1..621a035 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -29,13 +29,15 @@ jobs: steps: # Checkout repository - uses: actions/checkout@v4 - # Setup Dart SDK with JWT token + # Set up the Dart SDK and provision the OIDC token used for publishing. + # The `dart` command from this step will be shadowed by the one from the + # Flutter SDK below. - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 # Download flutter SDK - needed for publishing Flutter packages. Can also # publish pure Dart packages. # - # This will add the flutter/bin/dart executable to path, that sets up - # FLUTTER_ROOT. + # The dart binary from a Flutter SDK facilitates publishing both Flutter + # and pure-dart packages. - uses: flutter-actions/setup-flutter@d030cb603380106494f72d65a7e52462f380781f # Minimal package setup and dry run checks. - name: Install dependencies