Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[augmentations] Syntax highlighters implementation #56157

Open
itsjustkevin opened this issue Jul 8, 2024 · 3 comments
Open

[augmentations] Syntax highlighters implementation #56157

itsjustkevin opened this issue Jul 8, 2024 · 3 comments
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin. feature-augmentations Implementation of the augmentations feature type-enhancement A request for a change that isn't a bug

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@itsjustkevin itsjustkevin mentioned this issue Jul 8, 2024
Open
@dart-github-bot
Copy link
Collaborator

Summary: The issue concerns the implementation of syntax highlighters for augmentations, which are a new feature in Dart that allows for extending existing classes and libraries.

@dart-github-bot dart-github-bot added area-front-end Use area-front-end for front end / CFE / kernel format related issues. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Jul 8, 2024
@johnniwinther johnniwinther added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. and removed area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Jul 9, 2024
@eernstg eernstg added the feature-augmentations Implementation of the augmentations feature label Jul 9, 2024
@keertip keertip added area-intellij Tracking issues for the Dart IntelliJ plugin. and removed area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Jul 9, 2024
@keertip
Copy link
Contributor

keertip commented Jul 9, 2024

@DanTup, where would we track the VS code work?

@DanTup
Copy link
Collaborator

DanTup commented Jul 10, 2024 •
edited
Loading

We can have an issue for it here, or in Dart-Code. I suspect any changes to syntax highlighting will just be in the analysis_server/LSP mappings, and maybe also in the dart-syntax-highlighting repo (which I think we usually just track in issues here in the SDK) which will then just need rolling into Dart-Code.

(usually for these kinds of issues we have a checkbox list of the syntax highlighters - for example see #56187 - maybe we should add this here too?). Edit: And in #56196?

@lrhn lrhn removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin. feature-augmentations Implementation of the augmentations feature type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@DanTup @keertip @lrhn @eernstg @itsjustkevin @johnniwinther @dart-github-bot