[CP] fix precedence bug in dart2js #54697
Assignees
Labels
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
merge-to-beta
Comments
sigmundch
added
the
cherry-pick-review
|
/cc @srujzs @rakudrama I'll confirm once the change rolls into our internal systems to verify that no regressions are introduced as a result of this change. Overall I'd like to cherry-pick due to the high visibility of the bug in the new Dart/JS interop feature. Workarounds exist, but are not friendly (e.g. revert to the old JS-interop patterns). |
itsjustkevin
added
cherry-pick-approved
a-siva
added
the
area-web
|
Just to confirm, the change reached our internal systems and the signal is green. @itsjustkevin let me know if there are any constraints on when to land this. |
|
@sigmundch we are okay to land this based on approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
cb16f98
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/347645
Issue Description
Dart2js can generate invalid code for the new Dart/JS interop feature.
The problem results from a precedence bug in the js_ast representation in dart2js. This bug was not exploitable from code generated from Dart, but the new constructs added by Dart/JS interop make the precedence bug highly visible.
What is the fix
Fix the precedence bug when printing js_ast's.
Why cherry-pick
May affect any user of the new Dart/JS interop feature being released as part of Dart 3.3. The issue has been identified by both by internal and external developers.
Risk
low
Issue link(s)
#54534
Extra Info
No response
The text was updated successfully, but these errors were encountered: