sort members enforcement in analyzer should be in a presubmit

[jcollins-g]

Similar to dart format enforcement, sort members enforcement should be easy to put in a presubmit. It may be beneficial to have auto-sort on save, and a command-line displayed by the presubmit to sort members in a file.

[DanTup]

Would it make sense to have a lint/fix for this, and then it would be picked up by analysis (and can be detected/fixed with dart fix)?

In case it's useful, in VS Code it's possible to already run this on-save. I have this in my .code-workspace for the analysis server codebase:

"editor.codeActionsOnSave": {
	"source.organizeImports": true,
	"source.sortMembers": true
},

It can be a little confusing.. like you'll often add a new test in a test file somewhere and hit Save, and then watch it vanish from the screen. I've gotten used to adding @soloTest to new tests as something to quickly search for when that happens now 😄

[bwilkerson]

The option for 'source.sortMembers' didn't show up for me using completion support in the settings file editor. Might have been user error, or might have been an oversight.

[DanTup]

The option for 'source.sortMembers' didn't show up for me using completion support in the settings file editor. Might have been user error, or might have been an oversight.

It's unfortunately a VS Code limitation - see microsoft/vscode#161284. editor.codeActionsOnSave is a standard VS Code setting and currently it doesn't take into account the code actions that individual languages have registered for the completion.